Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Paul Burton <paul.burton@mips.com>
To:     Denis Efremov <efremov@linux.com>
CC:     Bjorn Helgaas <bhelgaas@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        Michal Simek <monstr@monstr.eu>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak
 function
Thread-Topic: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a
 weak function
Thread-Index: AQHVRYJLuix0vLkFjkOXtfNq2O4qQKbgooWA
Date:   Sun, 28 Jul 2019 22:49:55 +0000
Message-ID: <20190728224953.kezztdozc6k24ya3@pburton-laptop>
References: <20190728202213.15550-1-efremov@linux.com>
 <20190728202213.15550-2-efremov@linux.com>
In-Reply-To: <20190728202213.15550-2-efremov@linux.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: NeoMutt/20180716
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [73.93.4.225]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a04180d2-8bc9-41d1-8562-08d713ade8bf
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MWHPR2201MB1375;
x-ms-traffictypediagnostic: MWHPR2201MB1375:
x-microsoft-antispam-prvs: <MWHPR2201MB137543F7C0491F4E3EAFBFADC1C20@MWHPR2201MB1375.namprd22.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:983;
x-forefront-prvs: 01128BA907
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(366004)(346002)(376002)(136003)(39830400003)(396003)(199004)(189003)(66476007)(66556008)(71190400001)(66946007)(5660300002)(4326008)(71200400001)(76176011)(7416002)(6246003)(53936002)(256004)(6916009)(66446008)(64756008)(52116002)(99286004)(6116002)(25786009)(3846002)(66066001)(6512007)(9686003)(44832011)(305945005)(81156014)(6506007)(26005)(81166006)(316002)(478600001)(476003)(8676002)(186003)(68736007)(7736002)(229853002)(446003)(6436002)(8936002)(486006)(2906002)(33716001)(1076003)(102836004)(6486002)(54906003)(42882007)(11346002)(14454004)(386003)(58126008);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR2201MB1375;H:MWHPR2201MB1277.namprd22.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: wavecomp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: LGoXH/hfZ2EmVxj3CUBqAL1sE0i9frxkLeyaAv11qd5O/T0Vpk5dzHcq5B69mWk9zzcZGjP8mgNYqnYgk8VqWacbSL5U1PAXFUuEUxznedrRjQwQV2vPSyfCz2/0ML4894jFWL5b9GgZoPlrjT7dZ8vyafd0q/MtN4sU7xDwnvr+Quk4JuTf2quk4QpWt+gytYlAgN9WF/xbO6KcK2SOv/ebCUzSDWbybST6lhuT065w+DYtU/sfa+9g9lrHpN+xqIVS7fcS0DGisdVV0uROM8JS2Q+vNtIMz2MBVoRQGNaWh0MilRwAmDP6FXuXef+RGu3NNUfdXp0HIPTnpe2WMds9niDVqNKpSlA+naW4VSVt+Y5txDN3lNRiB2e+jDH4pvj72xFpYjGeMDxphd52Bnfx5LUtHJxgrIr28bB8Na8=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A2F7F7783DF44944999686D51424D191@namprd22.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: mips.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a04180d2-8bc9-41d1-8562-08d713ade8bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2019 22:49:55.3491
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 463607d3-1db3-40a0-8a29-970c56230104
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pburton@wavecomp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2201MB1375
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Denis,

On Sun, Jul 28, 2019 at 11:22:09PM +0300, Denis Efremov wrote:
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 9e700d9f9f28..1a19d0151b0a 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1870,25 +1870,13 @@ static inline const char *pci_name(const struct p=
ci_dev *pdev)
>  	return dev_name(&pdev->dev);
>  }
> =20
> -
>  /*
>   * Some archs don't want to expose struct resource to userland as-is
>   * in sysfs and /proc
>   */
> -#ifdef HAVE_ARCH_PCI_RESOURCE_TO_USER
> -void pci_resource_to_user(const struct pci_dev *dev, int bar,
> -			  const struct resource *rsrc,
> -			  resource_size_t *start, resource_size_t *end);
> -#else
> -static inline void pci_resource_to_user(const struct pci_dev *dev, int b=
ar,
> -		const struct resource *rsrc, resource_size_t *start,
> -		resource_size_t *end)
> -{
> -	*start =3D rsrc->start;
> -	*end =3D rsrc->end;
> -}
> -#endif /* HAVE_ARCH_PCI_RESOURCE_TO_USER */
> -
> +void __weak pci_resource_to_user(const struct pci_dev *dev, int bar,
> +				 const struct resource *rsrc,
> +				 resource_size_t *start, resource_size_t *end);
> =20
>  /*
>   * The world is not perfect and supplies us with broken PCI devices.

This is wrong - using __weak on the declaration in a header will cause
the weak attribute to be applied to all implementations too (presuming
the C files containing the implementations include the header). You then
get whichever impleentation the linker chooses, which isn't necessarily
the one you wanted.

checkpatch.pl should produce an error about this - see the
WEAK_DECLARATION error introduced in commit 619a908aa334 ("checkpatch:
add error on use of attribute((weak)) or __weak declarations").

Thanks,
    Paul