Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jul 2019 07:49:23 +0200
Message-ID: <s5hd0htpezg.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jia-Ju Bai <baijiaju1990@gmail.com>
Cc:     perex@perex.cz, gregkh@linuxfoundation.org, rfontana@redhat.com,
        allison@lohutok.net, tglx@linutronix.de,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] ALSA: core: seq: a possible double-lock bug in snd_seq_midisynth_remove()
In-Reply-To: <50b3b4c4-fe36-8c65-345b-f0a51193726c@gmail.com>
References: <50b3b4c4-fe36-8c65-345b-f0a51193726c@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 29 Jul 2019 05:54:07 +0200,
Jia-Ju Bai wrote:
> 
> In snd_seq_midisynth_remove(), there is a possible double-lock bug:
> snd_seq_midisynth_remove()
>     mutex_lock(&register_mutex); -- line 421
>     snd_seq_delete_kernel_client() --- line 436
>         seq_free_client() -- line 2244
>             mutex_lock(&register_mutex); -- line 294
> 
> This bug is found by a static analysis tool STCheck written by us.

No, it's a false-positive report.  Both register_mutex's are
static, hence they are local to each file.  That is, you're looking at
two different mutexes.


Takashi