Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAGnkfhySwXY7YwuQezyx6cEpemZW4Hox1_4fQJm3-5hvM3G6gw@mail.gmail.com>
 <20190729095047.k45isr7etq3xkyvr@willie-the-truck>
In-Reply-To: <20190729095047.k45isr7etq3xkyvr@willie-the-truck>
From:   Matteo Croce <mcroce@redhat.com>
Date:   Mon, 29 Jul 2019 12:08:33 +0200
Message-ID: <CAGnkfhxWsaDpxsE5Asj1dUxXGJvQr4_oq4ZDWtbn-zsbh_jkMQ@mail.gmail.com>
Subject: Re: build error
To:     Will Deacon <will@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 29, 2019 at 11:50 AM Will Deacon <will@kernel.org> wrote:
>
> Hi Matteo,
>
> On Sun, Jul 28, 2019 at 10:08:06PM +0200, Matteo Croce wrote:
> > I get this build error with 5.3-rc2"
> >
> > # make
> > arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT.  Stop.
> >
> > I didn't bisect the tree, but I guess that this kconfig can be related
> >
> > # grep CROSS_COMPILE_COMPAT .config
> > CONFIG_CROSS_COMPILE_COMPAT_VDSO=""
> >
> > Does someone have any idea? Am I missing something?
>
> Can you try something like the below?
>
> Will
>
> --->8
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index bb1f1dbb34e8..d35ca0aee295 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -52,7 +52,7 @@ ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y)
>
>    ifeq ($(CONFIG_CC_IS_CLANG), y)
>      $(warning CROSS_COMPILE_COMPAT is clang, the compat vDSO will not be built)
> -  else ifeq ($(CROSS_COMPILE_COMPAT),)
> +  else ifeq ("$(CROSS_COMPILE_COMPAT)","")
>      $(warning CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built)
>    else ifeq ($(shell which $(CROSS_COMPILE_COMPAT)gcc 2> /dev/null),)
>      $(error $(CROSS_COMPILE_COMPAT)gcc not found, check CROSS_COMPILE_COMPAT)

Hi, it doesn't fix. I've tried to print CROSS_COMPILE_COMPAT and it
seemed empty, but hexdump shows that it contains a new line:

# make 2>&1 |hexdump -C
00000000  61 72 63 68 2f 61 72 6d  36 34 2f 4d 61 6b 65 66  |arch/arm64/Makef|
00000010  69 6c 65 3a 35 39 3a 20  2a 2a 2a 20 43 52 4f 53  |ile:59: *** CROS|
00000020  53 5f 43 4f 4d 50 49 4c  45 5f 43 4f 4d 50 41 54  |S_COMPILE_COMPAT|
00000030  3d 27 13 27 2e 20 20 53  74 6f 70 2e 0a           |='.'.  Stop..|
0000003d

-- 
Matteo Croce
per aspera ad upstream