Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jul 2019 12:30:55 +0200
From:   Jiri Benc <jbenc@redhat.com>
To:     Jia-Ju Bai <baijiaju1990@gmail.com>
Cc:     davem@davemloft.net, sbrivio@redhat.com, sd@queasysnail.net,
        liuhangbin@gmail.com, dsahern@gmail.com, natechancellor@gmail.com,
        tglx@linutronix.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: geneve: Fix a possible null-pointer dereference in
 geneve_link_config()
Message-ID: <20190729123055.5a7ba416@redhat.com>
In-Reply-To: <20190729102611.2338-1-baijiaju1990@gmail.com>
References: <20190729102611.2338-1-baijiaju1990@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 29 Jul 2019 18:26:11 +0800, Jia-Ju Bai wrote:
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -1521,9 +1521,10 @@ static void geneve_link_config(struct net_device *dev,
>  		rt = rt6_lookup(geneve->net, &info->key.u.ipv6.dst, NULL, 0,
>  				NULL, 0);
>  
> -		if (rt && rt->dst.dev)
> +		if (rt && rt->dst.dev) {
>  			ldev_mtu = rt->dst.dev->mtu - GENEVE_IPV6_HLEN;
> -		ip6_rt_put(rt);
> +			ip6_rt_put(rt);
> +		}
>  		break;
>  	}
>  #endif

Are you sure rt6_lookup can never return a non-NULL rt with rt->dst.dev
being NULL? You'd leak the reference in such case.

 Jiri