Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3262061ybi; Mon, 29 Jul 2019 03:40:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHfWIQD0QKlOAH/emNl2v0Ndtwm89YUDyyB9x8N7jeLo9iV3YH9gJsF2rDxowM9TPi/6ol X-Received: by 2002:a17:902:aa03:: with SMTP id be3mr109089520plb.240.1564396831800; Mon, 29 Jul 2019 03:40:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564396831; cv=none; d=google.com; s=arc-20160816; b=1C1whgwSz1fIi16MuRIavGOlsYHQ4vTyq3/G4xu2uHMSxaaz/UPqAIH1yoge6+GCbq h+I39eEamuNi7qqwwNK1EfFuk4kBQibqFaFKi3FJc4E5XjnTCRfB2a+YuKJVjKJ479lz SaN972Uzb9mipBg7FC3OiUEKS59Ac4Gtv+Bjvjgib/ul4rWWdhiWhAQTqE/4wn/clOc1 pfL6z2uTdFY6GHcCLSu4rQLiyT+8IrKzeSbOOGRD1Cr1M1groAznfk+iRll0BvEV9ZEU uWy2imShe8/to/L+Hl3ZxbB5twg4zd0giqit/yQV+WL6rcqdeRi0F972BQYlKsx/gD1D p+fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KAggO34scn31WY7TrlvVv9v9Jlh8D/gvQUy8nUnXkHk=; b=neXJCb66WRPafbTzK9bUedzY2ldWUxu70RWBEpe3bPNlh2qVBQRmMXY5LOzr3gZksi lOFv2vrNvra/WS7psxAT11Fya+AnNN65WEoQVm81gNhPZlbgRktC7QeE0mVhaitBScu8 p4hjHv68MwEND6G0bw+AICAg1ow+Fo8JJwU41t+KPn78U00Mpsz/nCK81Y0nu90HuLeN AO8jerCEokgisl4WbrFdWunph0Q9T9tzjVxn8AFjtv01+qWKW/JwLXPNsqovH496Xuct sfFJ8TO+04NtATqqNDJo1kCZrooQSBOlW/Ex3bLLCvat8tYGuF/J88BH9rPVyeAURb8O ABgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=nBEkEzd3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v11si22862564pjn.44.2019.07.29.03.40.16; Mon, 29 Jul 2019 03:40:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=nBEkEzd3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728331AbfG2Kit (ORCPT + 99 others); Mon, 29 Jul 2019 06:38:49 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37654 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728151AbfG2Kit (ORCPT ); Mon, 29 Jul 2019 06:38:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KAggO34scn31WY7TrlvVv9v9Jlh8D/gvQUy8nUnXkHk=; b=nBEkEzd3Pwsz4U13WP8pfhzI0 S7e8IJB4PaJ/+Kn+2q8cRtyp1OCQNMNmnM87aiwj94/vHkqSNRq6Pjlj0+Ap6FPdbzJP51TtUd7Go +y1E4dh8Ac9FjHQa8YwvLXowOyTQkZXeTLxc0P+sAU8x64nOoJnGjAmNCnI7XtL6O0OfB+dCcRPuH IcjUw8lQwA43toWGGElJGCLShD9u2jkU4RoNOAUT9Wri7lS2khLOgvGWwWYGzLYVBWcUMb/90KTGe h+7yrY/G/eBtgbj6w32Gi4BIcDAwydt/KJI1TE7ENc3JgFvrTVFN2lyaoHgNPGcmwiZuwFJC1zDvz tr+kRNn/Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hs33G-0002r4-1B; Mon, 29 Jul 2019 10:38:46 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 76B5F203BF70D; Mon, 29 Jul 2019 12:38:44 +0200 (CEST) Date: Mon, 29 Jul 2019 12:38:44 +0200 From: Peter Zijlstra To: Davidlohr Bueso Cc: mingo@kernel.org, longman@redhat.com, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH -tip] locking/rwsem: Check for operations on an uninitialized rwsem Message-ID: <20190729103844.GA31381@hirez.programming.kicks-ass.net> References: <20190729044735.9632-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729044735.9632-1-dave@stgolabs.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 28, 2019 at 09:47:35PM -0700, Davidlohr Bueso wrote: > Currently rwsems is the only locking primitive that lacks this > debug feature. Add it under CONFIG_DEBUG_RWSEMS and do the magic > checking in the locking fastpath (trylock) operation such that > we cover all cases. The unlocking part is pretty straightforward. Thanks!