Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jul 2019 12:52:21 +0200
From:   Jiri Benc <jbenc@redhat.com>
To:     Jia-Ju Bai <baijiaju1990@gmail.com>
Cc:     davem@davemloft.net, sbrivio@redhat.com, sd@queasysnail.net,
        liuhangbin@gmail.com, dsahern@gmail.com, natechancellor@gmail.com,
        tglx@linutronix.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: geneve: Fix a possible null-pointer dereference in
 geneve_link_config()
Message-ID: <20190729125221.00baf700@redhat.com>
In-Reply-To: <20190729123055.5a7ba416@redhat.com>
References: <20190729102611.2338-1-baijiaju1990@gmail.com>
        <20190729123055.5a7ba416@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 29 Jul 2019 12:30:55 +0200, Jiri Benc wrote:
> Are you sure rt6_lookup can never return a non-NULL rt with rt->dst.dev
> being NULL? You'd leak the reference in such case.

In fact, you're introducing a bug, not fixing one. ip6_rt_put does
accept NULL parameter. And it seems you already have been told that?

Nacked-by: Jiri Benc <jbenc@redhat.com>

 Jiri