Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3349062ybi; Mon, 29 Jul 2019 05:09:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzbHy3IGnO/9K2OQ8iK0anyRnYYRgj97H4mC5BwqxdEKFi4hhQSfdEFLXdHgOrtWS/0myME X-Received: by 2002:a17:902:1a6:: with SMTP id b35mr13700034plb.190.1564402175759; Mon, 29 Jul 2019 05:09:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564402175; cv=none; d=google.com; s=arc-20160816; b=L6ap2zCaphMh0AYO0i1XM3eKnGOXwvY9N+C55TYWdV0qXks3RzSJMzbgzvOwZy/h/K yg6/gxXtYFusPz4SS5awo4av492jqwHke6nA74LVu/tfeyAgbLTw7+pr3RjVQT4fQagd 9FyqRn7EYjIvtSmCtg+uofP9mVp46xWLZHi1uVr40EFvUEKrskrb8pc7TuMuJE+EEwf3 Qv0AN7ZFwsbtbWjWd4jW5eM/+t224Bt6HI5btRplO1Ci20n3NK/Q7iq0jfhBGQTn7eS4 8jVdeokZ8VEmiFLPW6vahv+ngUFcE94KrYevyYGQ4AnbqxSxf6Qj+cNCTucayxcgrM9Q 2fJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LNpnWgm9teS9/G2vGxNANHeu1/rJNv6rpYjqNAcV2nQ=; b=XPNbpolErzhPfdkQ+3s+0wTQuYkmpZmFFlbffdGUl5qG7NFcGi/YAhTvIYz6w3SfRW 9qGdoi1f/zTN6sMRf3fnbWN6FHhZdWtj7pm2NYvnQZOZE7W4ayvmVUlSzdFNxP1onbCf CUb8XIIiYQ5tiVfdDqChKTOM0uj1reSJJ2cfi8Jv0bbvREmLVE9OF8Bye/AWamMD8L11 WQLHIU1CY1Fm/chguvCvYJ7JzNtFrFD7wbkDILUFm+AcQXI7jn3RYO8WvdUbmCIq+2By 7P0dxGzsqr5AUniokq8j36uJqiL8RFj36dn4laEO/5I8a0g5eXUPCEJeEaIsnukxIFF7 iYeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q16si27453644pgv.140.2019.07.29.05.09.19; Mon, 29 Jul 2019 05:09:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727875AbfG2ItB (ORCPT + 99 others); Mon, 29 Jul 2019 04:49:01 -0400 Received: from inva020.nxp.com ([92.121.34.13]:55122 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727850AbfG2Isy (ORCPT ); Mon, 29 Jul 2019 04:48:54 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 13DF91A032F; Mon, 29 Jul 2019 10:48:52 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 401CC1A1455; Mon, 29 Jul 2019 10:48:47 +0200 (CEST) Received: from titan.ap.freescale.net (TITAN.ap.freescale.net [10.192.208.233]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 0ABBF40313; Mon, 29 Jul 2019 16:48:38 +0800 (SGT) From: Anson.Huang@nxp.com To: rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linux-imx@nxp.com Subject: [PATCH V2 4/4] thermal: qoriq: Add clock operations Date: Mon, 29 Jul 2019 16:39:15 +0800 Message-Id: <20190729083915.4855-4-Anson.Huang@nxp.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20190729083915.4855-1-Anson.Huang@nxp.com> References: <20190729083915.4855-1-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anson Huang Some platforms like i.MX8MQ has clock control for this module, need to add clock operations to make sure the driver is working properly. Signed-off-by: Anson Huang Reviewed-by: Guido Günther --- Changes since V1: - use devm_clk_get_optional() instead of devm_clk_get(). --- drivers/thermal/qoriq_thermal.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index 2b2f79b..0ae45c0 100644 --- a/drivers/thermal/qoriq_thermal.c +++ b/drivers/thermal/qoriq_thermal.c @@ -2,6 +2,7 @@ // // Copyright 2016 Freescale Semiconductor, Inc. +#include #include #include #include @@ -72,6 +73,7 @@ struct qoriq_sensor { struct qoriq_tmu_data { struct qoriq_tmu_regs __iomem *regs; + struct clk *clk; bool little_endian; struct qoriq_sensor *sensor[SITES_MAX]; }; @@ -208,6 +210,16 @@ static int qoriq_tmu_probe(struct platform_device *pdev) return PTR_ERR(data->regs); } + data->clk = devm_clk_get_optional(&pdev->dev, NULL); + if (IS_ERR(data->clk)) + return PTR_ERR(data->clk); + + ret = clk_prepare_enable(data->clk); + if (ret) { + dev_err(&pdev->dev, "Failed to enable clock\n"); + return ret; + } + qoriq_tmu_init_device(data); /* TMU initialization */ ret = qoriq_tmu_calibration(pdev); /* TMU calibration */ @@ -235,6 +247,8 @@ static int qoriq_tmu_remove(struct platform_device *pdev) /* Disable monitoring */ tmu_write(data, TMR_DISABLE, &data->regs->tmr); + clk_disable_unprepare(data->clk); + platform_set_drvdata(pdev, NULL); return 0; @@ -250,14 +264,21 @@ static int __maybe_unused qoriq_tmu_suspend(struct device *dev) tmr &= ~TMR_ME; tmu_write(data, tmr, &data->regs->tmr); + clk_disable_unprepare(data->clk); + return 0; } static int __maybe_unused qoriq_tmu_resume(struct device *dev) { u32 tmr; + int ret; struct qoriq_tmu_data *data = dev_get_drvdata(dev); + ret = clk_prepare_enable(data->clk); + if (ret) + return ret; + /* Enable monitoring */ tmr = tmu_read(data, &data->regs->tmr); tmr |= TMR_ME; -- 2.7.4