Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3420903ybi; Mon, 29 Jul 2019 06:18:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwGvG4vzjlpu7VveQQQIC6g7NBUbs7lRrDzQqPB8O3OhXQTW5R/9KwyUyB3XGY7dvEO3OOO X-Received: by 2002:a17:902:b612:: with SMTP id b18mr83542031pls.8.1564406327528; Mon, 29 Jul 2019 06:18:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564406327; cv=none; d=google.com; s=arc-20160816; b=WoFxnStU2lSIm2ye0q2VBJcCcJS+oGX2yI87VGwKMK2yvWrQzo8eCJHnws0kq2wYOt ZjmSm5hNPW4+c5oRNnDPHf/MQcx1D6hki8+jT7kzv1Wy8qq/SnNEAIzrYAKU/DJa7dHF mmw8hIN//Vsyt0/caQBrxGVxHiLmMzNQOQAyPINksgsiIEB5nyVd4GbJhzKn0R1vh9UO CXyv7S5Ek8Xpj8O1NEj+ZMadrRhOCijRubgqgqmRv3n6RzC3Az4Ts3RD/9Wn/ECSbQ55 l+Y3u3gc3FOr6fF9IihNVzEcdhdn9Z38tZyaRi7Ud4D5qsuIVSvII70xEOXFt0ekW0PR ppgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=icsox7tciUqr1UuSobAsZyd7Ab8KfGAFyKTmMrTtSsg=; b=UkdBnseqTlCcBA1ZdNA8Y0h9OvQQgupjwGwF77SILqtUX63XgkhUlDpdiD5MHciiIP 5G2Cf1e8x8X6uXC9HbhAmc2T7D/wE3ll2CGIufEd06fdXUTra5IhegbXZDQBx66U7SsM 8Ite9qKbFsUbY4Rf8MEl4HFXhyWP9F5L+rr50UzyTvEc0hy/5HSHrsA6idgbuNbMTMBp 0rJL1+KK/dBoqZMwRZT0PLyNxBGtR/J3iQ/MDQwbRrcEO77GmNuQkfXIXsvfpzapKQO8 l+3Jb5il5GfzRX6IVG2zs0a2UIAJgNQjYNcfBxbFHINsYXs1oz8BofkPI+bNWd90s3Wy LrTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=My1MHpeZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f186si25796110pgc.438.2019.07.29.06.18.18; Mon, 29 Jul 2019 06:18:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=My1MHpeZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbfG2K3o (ORCPT + 99 others); Mon, 29 Jul 2019 06:29:44 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.114]:33486 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728030AbfG2K3o (ORCPT ); Mon, 29 Jul 2019 06:29:44 -0400 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 9A1CF106EFC for ; Mon, 29 Jul 2019 05:28:10 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id s2t0h3d1vYTGMs2t0hrj8S; Mon, 29 Jul 2019 05:28:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=icsox7tciUqr1UuSobAsZyd7Ab8KfGAFyKTmMrTtSsg=; b=My1MHpeZDnOX4AMgXTHICb3OGw /hvLGu5B6UJ2DdF1N9Rh16Muspv495MxzVS7BK/rCqbTm5vaETSBAtCsMiIGCNwR1eXHDr2O+AQ2L Tqg4UEqFCzruk0sR06E0vvI6Z3cXIqGbY+t8pBL0fWKg+NFm2S/1aThTjGwGA6vTGFdjncF8mVvmL lAkoxCLguq4T/EQ5AwvjCNN6vRtTA5rU8UgjB6msceiK5YcrvjRakZwBaRmML9o3NqHp48v/peJdC oxcbUWj0BUwq6pqmC+COBo8BWlPDYeNZ21OW6rTRuh87ZbsrvEuWZVQEfNL2r/kTc6/0S59bQyz1N Yr+AeEGw==; Received: from [187.192.11.120] (port=41698 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1hs2t0-004Cex-5T; Mon, 29 Jul 2019 05:28:10 -0500 Subject: Re: [PATCH] drm: mali-dp: Mark expected switch fall-through To: Liviu Dudau , Anders Roxell Cc: airlied@linux.ie, daniel@ffwll.ch, stable@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20190726112741.19360-1-anders.roxell@linaro.org> <20190729095803.hd7ehqjc4zlqztv3@e110455-lin.cambridge.arm.com> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= mQINBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABtCxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPokCPQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA7kCDQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAYkCJQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: Date: Mon, 29 Jul 2019 05:28:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190729095803.hd7ehqjc4zlqztv3@e110455-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.11.120 X-Source-L: No X-Exim-ID: 1hs2t0-004Cex-5T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [187.192.11.120]:41698 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/19 4:58 AM, Liviu Dudau wrote: >> case MW_RESTART: >> drm_writeback_signal_completion(&malidp->mw_connector, 0); >> - /* fall through to a new start */ > > It's a shame that the compiler throws a warning here, it would've been really > useful to keep the hint that going back to a new start is intentional without > having to type another comment. > You don't have to remove the rest of the comment. For a one-line comment this works just fine: /* fall through - to a new start */ -- Gustavo