Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3421870ybi; Mon, 29 Jul 2019 06:19:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVePsao2RfCM481PG/T4tESqTSNuQzIenphAXXxv+HC3ivR8VZfbVoNF27IkVTsDvKjvKP X-Received: by 2002:a62:770e:: with SMTP id s14mr35425963pfc.150.1564406376360; Mon, 29 Jul 2019 06:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564406376; cv=none; d=google.com; s=arc-20160816; b=hXsWBaQse3QnDm2C1Our8dM+rYTXLDuc02zcRTtnPwg0Xinpzbr1/oiNnABEtwikYx irc4tPEsXAxxfK6JI2PzoDklIS42vG1RhmE00j0xoktxThNkewHHeL4df39JaFRyNcdX ScA6OH7PLEGVqThKfkD8gVkj5X2EX7EBRD1RIqN7DpcwXicRS9OUcaaChE+TSOF12ml4 x77vi4wd47cxap7vtNZGJ23vtKTO2jlQJznuJvIHphfZ/473I9sze2hPZ45mh5iMIJ4d iaFMy4tu27N4ZH5d/bxIl1NnCgJ0XBwLPFsPyhxsbqs9+Mkr5YjSU9s7eHKwbEziDFD5 6zeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=b1IOwcoJMPsMnYk9o6iEDDAPZUPJpTywN0Iu8SOB5y4=; b=uB4sYi4IusMYxkUdlfwFrO+4DOBvCsLt5KZUJSn7j6tw1jBY1LAqimXN3QAsuAwfnC Dpg1+/JB1bpB8+/rGVbXGHwEOWDhgbNgFWMvwmylZP/ungFxkWd/WQ2306jl6KIFYcUw alB7U/dZmIzcN0cZT+J6LsP1fuJr00ESaM/Y2VOfCmN1ejEAK2bnawAacqKRrMXMboec FFu2YfsuoJKUTcn+gMR+yHP984+2+PUqptKXwDIVhlHw7jsJlJBpmxYatnVVwRrmtZse wImbslTA+8rdjSJEafrSJ6mQJdNSlFC2SRSfM5+iXl02v05qTEqle1FYmWplAoZulkW+ SvYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si27044868pjd.105.2019.07.29.06.19.21; Mon, 29 Jul 2019 06:19:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728308AbfG2Kiq (ORCPT + 99 others); Mon, 29 Jul 2019 06:38:46 -0400 Received: from foss.arm.com ([217.140.110.172]:41696 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728151AbfG2Kiq (ORCPT ); Mon, 29 Jul 2019 06:38:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5DF5E344; Mon, 29 Jul 2019 03:38:45 -0700 (PDT) Received: from [10.1.197.61] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90E693F694; Mon, 29 Jul 2019 03:38:44 -0700 (PDT) Subject: Re: [PATCH 3/4] irqchip: ingenic: Get virq number from IRQ domain To: Paul Cercueil , Thomas Gleixner , Jason Cooper Cc: linux-kernel@vger.kernel.org, od@zcrc.me, Zhou Yanjie References: <20190727191741.30317-1-paul@crapouillou.net> <20190727191741.30317-3-paul@crapouillou.net> From: Marc Zyngier Openpgp: preference=signencrypt Autocrypt: addr=marc.zyngier@arm.com; prefer-encrypt=mutual; keydata= mQINBE6Jf0UBEADLCxpix34Ch3kQKA9SNlVQroj9aHAEzzl0+V8jrvT9a9GkK+FjBOIQz4KE g+3p+lqgJH4NfwPm9H5I5e3wa+Scz9wAqWLTT772Rqb6hf6kx0kKd0P2jGv79qXSmwru28vJ t9NNsmIhEYwS5eTfCbsZZDCnR31J6qxozsDHpCGLHlYym/VbC199Uq/pN5gH+5JHZyhyZiNW ozUCjMqC4eNW42nYVKZQfbj/k4W9xFfudFaFEhAf/Vb1r6F05eBP1uopuzNkAN7vqS8XcgQH qXI357YC4ToCbmqLue4HK9+2mtf7MTdHZYGZ939OfTlOGuxFW+bhtPQzsHiW7eNe0ew0+LaL 3wdNzT5abPBscqXWVGsZWCAzBmrZato+Pd2bSCDPLInZV0j+rjt7MWiSxEAEowue3IcZA++7 ifTDIscQdpeKT8hcL+9eHLgoSDH62SlubO/y8bB1hV8JjLW/jQpLnae0oz25h39ij4ijcp8N t5slf5DNRi1NLz5+iaaLg4gaM3ywVK2VEKdBTg+JTg3dfrb3DH7ctTQquyKun9IVY8AsxMc6 lxl4HxrpLX7HgF10685GG5fFla7R1RUnW5svgQhz6YVU33yJjk5lIIrrxKI/wLlhn066mtu1 DoD9TEAjwOmpa6ofV6rHeBPehUwMZEsLqlKfLsl0PpsJwov8TQARAQABtCNNYXJjIFp5bmdp ZXIgPG1hcmMuenluZ2llckBhcm0uY29tPokCTwQTAQIAOQIbAwYLCQgHAwIGFQgCCQoLBBYC AwECHgECF4AWIQSf1RxT4LVjGP2VnD0j0NC60T16QwUCXR3BUgAKCRAj0NC60T16Qyd/D/9s x0puxd3lI+jdLMEY8sTsNxw/+CZfyKaHtysasZlloLK7ftYhRUc63mMW2mrvgB1GEnXYIdj3 g6Qo4csoDuN+9EBmejh7SglM/h0evOtrY2V5QmZA/e/Pqfj0P3N/Eb5BiB3R4ptLtvKCTsqr 3womxCRqQY3IrMn1s2qfpmeNLUIfCUtgh8opzPtFuFJWVBzbzvhPEApZzMe9Vs1O2P8BQaay QXpbzHaKruthoLICRzS/3UCe0N/mBZQRKHrqhPwvjZdO0KMqjSsPqfukOJ8bl5jZxYk+G/3T 66Z4JUpZ7RkcrX7CvBfZqRo19WyWFfjGz79iVMJNIEkJvJBANbTSiWUC6IkP+zT/zWYzZPXx XRlrKWSBBqJrWQKZBwKOLsL62oQG7ARvpCG9rZ6hd5CLQtPI9dasgTwOIA1OW2mWzi20jDjD cGC9ifJiyWL8L/bgwyL3F/G0R1gxAfnRUknyzqfpLy5cSgwKCYrXOrRqgHoB+12HA/XQUG+k vKW8bbdVk5XZPc5ghdFIlza/pb1946SrIg1AsjaEMZqunh0G7oQhOWHKOd6fH0qg8NssMqQl jLfFiOlgEV2mnaz6XXQe/viXPwa4NCmdXqxeBDpJmrNMtbEbq+QUbgcwwle4Xx2/07ICkyZH +7RvbmZ/dM9cpzMAU53sLxSIVQT5lj23WLkCDQROiX9FARAAz/al0tgJaZ/eu0iI/xaPk3DK NIvr9SsKFe2hf3CVjxriHcRfoTfriycglUwtvKvhvB2Y8pQuWfLtP9Hx3H+YI5a78PO2tU1C JdY5Momd3/aJBuUFP5blbx6n+dLDepQhyQrAp2mVC3NIp4T48n4YxL4Og0MORytWNSeygISv Rordw7qDmEsa7wgFsLUIlhKmmV5VVv+wAOdYXdJ9S8n+XgrxSTgHj5f3QqkDtT0yG8NMLLmY kZpOwWoMumeqn/KppPY/uTIwbYTD56q1UirDDB5kDRL626qm63nF00ByyPY+6BXH22XD8smj f2eHw2szECG/lpD4knYjxROIctdC+gLRhz+Nlf8lEHmvjHgiErfgy/lOIf+AV9lvDF3bztjW M5oP2WGeR7VJfkxcXt4JPdyDIH6GBK7jbD7bFiXf6vMiFCrFeFo/bfa39veKUk7TRlnX13go gIZxqR6IvpkG0PxOu2RGJ7Aje/SjytQFa2NwNGCDe1bH89wm9mfDW3BuZF1o2+y+eVqkPZj0 mzfChEsiNIAY6KPDMVdInILYdTUAC5H26jj9CR4itBUcjE/tMll0n2wYRZ14Y/PM+UosfAhf YfN9t2096M9JebksnTbqp20keDMEBvc3KBkboEfoQLU08NDo7ncReitdLW2xICCnlkNIUQGS WlFVPcTQ2sMAEQEAAYkCHwQYAQIACQUCTol/RQIbDAAKCRAj0NC60T16QwsFD/9T4y30O0Wn MwIgcU8T2c2WwKbvmPbaU2LDqZebHdxQDemX65EZCv/NALmKdA22MVSbAaQeqsDD5KYbmCyC czilJ1i+tpZoJY5kJALHWWloI6Uyi2s1zAwlMktAZzgGMnI55Ifn0dAOK0p8oy7/KNGHNPwJ eHKzpHSRgysQ3S1t7VwU4mTFJtXQaBFMMXg8rItP5GdygrFB7yUbG6TnrXhpGkFBrQs9p+SK vCqRS3Gw+dquQ9QR+QGWciEBHwuSad5gu7QC9taN8kJQfup+nJL8VGtAKgGr1AgRx/a/V/QA ikDbt/0oIS/kxlIdcYJ01xuMrDXf1jFhmGZdocUoNJkgLb1iFAl5daV8MQOrqciG+6tnLeZK HY4xCBoigV7E8KwEE5yUfxBS0yRreNb+pjKtX6pSr1Z/dIo+td/sHfEHffaMUIRNvJlBeqaj BX7ZveskVFafmErkH7HC+7ErIaqoM4aOh/Z0qXbMEjFsWA5yVXvCoJWSHFImL9Bo6PbMGpI0 9eBrkNa1fd6RGcktrX6KNfGZ2POECmKGLTyDC8/kb180YpDJERN48S0QBa3Rvt06ozNgFgZF Wvu5Li5PpY/t/M7AAkLiVTtlhZnJWyEJrQi9O2nXTzlG1PeqGH2ahuRxn7txA5j5PHZEZdL1 Z46HaNmN2hZS/oJ69c1DI5Rcww== Organization: ARM Ltd Message-ID: <538e79e5-539b-3066-b662-8ed4ec8bf261@arm.com> Date: Mon, 29 Jul 2019 11:38:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190727191741.30317-3-paul@crapouillou.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+ Zhou Yanjie] Paul, On 27/07/2019 20:17, Paul Cercueil wrote: > Get the virq number from the IRQ domain instead of calculating it from > the hardcoded irq base. > > Signed-off-by: Paul Cercueil > --- > drivers/irqchip/irq-ingenic.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-ingenic.c b/drivers/irqchip/irq-ingenic.c > index d97a3a500249..82a079fa3a3d 100644 > --- a/drivers/irqchip/irq-ingenic.c > +++ b/drivers/irqchip/irq-ingenic.c > @@ -21,6 +21,7 @@ > > struct ingenic_intc_data { > void __iomem *base; > + struct irq_domain *domain; > unsigned num_chips; > }; > > @@ -34,6 +35,7 @@ struct ingenic_intc_data { > static irqreturn_t intc_cascade(int irq, void *data) > { > struct ingenic_intc_data *intc = irq_get_handler_data(irq); > + struct irq_domain *domain = intc->domain; > uint32_t irq_reg; > unsigned i; > > @@ -43,7 +45,8 @@ static irqreturn_t intc_cascade(int irq, void *data) > if (!irq_reg) > continue; > > - generic_handle_irq(__fls(irq_reg) + (i * 32) + JZ4740_IRQ_BASE); > + irq = irq_find_mapping(domain, __fls(irq_reg) + (i * 32)); > + generic_handle_irq(irq); > } > > return IRQ_HANDLED; > @@ -95,6 +98,8 @@ static int __init ingenic_intc_of_init(struct device_node *node, > goto out_unmap_base; > } > > + intc->domain = domain; > + > for (i = 0; i < num_chips; i++) { > /* Mask all irqs */ > writel(0xffffffff, intc->base + (i * CHIP_SIZE) + > This is likely to conflict with this[1] series, which turns the intc_cascade function into a chained handler (which it should have been from the start). Can you please work with Zhou to post a unified series? Having two people working independently on the same file is likely to end badly otherwise. Thanks, M. [1] https://lore.kernel.org/lkml/1564335273-22931-1-git-send-email-zhouyanjie@zoho.com/ -- Jazz is not dead. It just smells funny...