Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3448322ybi; Mon, 29 Jul 2019 06:46:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRcf4gxl3I4hcr+xJMW/L0Qm/6yCfyKELeSxup/kYI1R8LmPK3JIwagDXf27ctDB/Ibwp0 X-Received: by 2002:a62:18d4:: with SMTP id 203mr37078397pfy.165.1564408018472; Mon, 29 Jul 2019 06:46:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564408018; cv=none; d=google.com; s=arc-20160816; b=v+eHZ7fbhyM4haq1Y1KvsJ9pTBbPeYFju/XH6ROH6fF9qi4zUtoIw5q6rGaBBH77X5 EXt2B5B+A7iENzqoCWTkbyYRKHAx6I2kEWI1p4gGdcxatZU1GJFD1Zb1ml2P/lYmlf1/ FM8MzjOpuUeqpPFHEihuaj43Jp8MN06CnW+O8CyaZUKPfdqSGXSVw8N8LbYXmOivf4Nl FPXLd/EXqIg0jlq9cLDqUiLhSoFWnN/8o4pnvYo/BTwFG2rRL9BsLpq5HD1PKo1KdwMC Xo5AhaQhBq1VUHzU+enYNxyz+QiKSX8d9akD3kXmp/QATtVB8FJm7XHnW3oUaoiR/5hh QPCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=DGd6lNjY14Gr5P3D/gF3LHeqr2EXL8RX8b0BvIQEHPs=; b=KCaXAvHdI67OfYIl2/IiI7vxJO9tm4sEbjdwmo/8Uc15ZIET2xnA+Ng3lfaKga0Zuj mSx6SYNZw66vInVYmimDyJmoRrsMp9hP2URIT5Qc2Kg3okaiwDBwKXXhfZg7OrjJHIVg ygYAR2vja7okk4OGZOEFIku7kHVWjG/RoRi+9q23iQi+pvtZZXbSy4xE5EEBFxFhNwhJ 9V+IquOacoI+chfZ89hfIPcsnn1m/z7yVI7OsAodnY1Fl0VOWoEOPS/ApJ5NWj8VIGGY 96flh1st+JQW12lQU6A60j9BJm52oQMRPKvheeSSBevoGF3DdHBgoTc1el+DU10+pyPb TMvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=KWfxRLwM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t143si29182812pgb.542.2019.07.29.06.46.43; Mon, 29 Jul 2019 06:46:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=KWfxRLwM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbfG2MUw (ORCPT + 99 others); Mon, 29 Jul 2019 08:20:52 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:40345 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfG2MUw (ORCPT ); Mon, 29 Jul 2019 08:20:52 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45xzL76qMgz9s7T; Mon, 29 Jul 2019 22:20:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1564402848; bh=3ZkE3Wh5jiD52ViBI3ydmbVsv7nbSViohUmvTLpbK70=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KWfxRLwMNOziGpWS6BoNYIOFdG/0wx8TN+5p2DFAZJ0yBReJYDTgOYdDgW3P82Qcc MC8cQo+h4DZJ/EsAc3f/6m39bl881hwKgkervD4W41jonANn+rQUaNKI2SuhCmHAWn NqXGuM8tBdJntI3LQ+CSEYkpDQMTHXbLwT1Pusgs16ovgQ0iV/jOCNBQt/Gw7uzu05 kHvBIoRAs4E09TbJODyukwcBd3vXrgpP/5s8U0MbwWutQUj9zbTSU3RygqIeDtvlbd JgQEZr1H3odoftAwmqgfw2unfVC5U59siY9i1uZ+mRT4uXX5hJ7nogLy7fI4Tz48R2 kySap4hjMXHnw== Date: Mon, 29 Jul 2019 22:20:45 +1000 From: Stephen Rothwell To: Denis Efremov Cc: Masahiro Yamada , Michal Marek , Emil Velikov , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] modpost: check for static EXPORT_SYMBOL* functions Message-ID: <20190729222045.4b491ffb@canb.auug.org.au> In-Reply-To: <20190729092250.32670-1-efremov@linux.com> References: <20190714152817.24693-1-efremov@linux.com> <20190729092250.32670-1-efremov@linux.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Ak=QLX=2NJUyzZgETBpXpbk"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/Ak=QLX=2NJUyzZgETBpXpbk Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Denis, Just a small note (nit? :-)): On Mon, 29 Jul 2019 12:22:50 +0300 Denis Efremov wrote: > > + if (s->is_static) > + warn("\"%s\" [%s] is the static %s\n", This read a little wrong to me, maybe "is a static"? --=20 Cheers, Stephen Rothwell --Sig_/Ak=QLX=2NJUyzZgETBpXpbk Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl0+5J0ACgkQAVBC80lX 0GxG5wgApfJ4ZYIP4/nrvt1ZpHnsVu8rZOSuHQBxLepKCgo2wcYPrgDfSyyhrsYR qK3mVW9IjuHCqRbbjoPQMzrHREdO11fIOvrGQyDNHE2FkUdkd1tr2SnBQmNov6LO VtsyfEl6Iubq0Fv4RCALpas0lkdww7oz5fFIi10E51wX24p3q0OWLNJo3/6bsATi XRuaH5VJ94fbWODxfQQeLpab+20pQABFUZQPM81pWG1jDHhod4IkCz1sJM/TC4IP oOPhA9mBh/Pd8B9i88Mxcy1Jk62bkM7f1VG/lUHyY7hV8yTRHPlcGaHUgw2ye2XF GiYlOFlRCmQKIpL1dt1JBY5kC286rw== =Axup -----END PGP SIGNATURE----- --Sig_/Ak=QLX=2NJUyzZgETBpXpbk--