Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: efremov@linux.com
Subject: Re: [PATCH v2] modpost: check for static EXPORT_SYMBOL* functions
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Masahiro Yamada <yamada.masahiro@socionext.com>,
        Michal Marek <michal.lkml@markovi.net>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190714152817.24693-1-efremov@linux.com>
 <20190729092250.32670-1-efremov@linux.com>
 <20190729222045.4b491ffb@canb.auug.org.au>
From:   Denis Efremov <efremov@linux.com>
Message-ID: <2b6fc296-bf42-f99d-e420-3293471db033@linux.com>
Date:   Mon, 29 Jul 2019 15:47:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190729222045.4b491ffb@canb.auug.org.au>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/29/19 3:20 PM, Stephen Rothwell wrote:
> Hi Denis,
> 
> Just a small note (nit? :-)):
> 
> On Mon, 29 Jul 2019 12:22:50 +0300 Denis Efremov <efremov@linux.com> wrote:
>>
>> +			if (s->is_static)
>> +				warn("\"%s\" [%s] is the static %s\n",
> 
> This read a little wrong to me, maybe "is a static"?
> 

Thank you! I will fix this in v3 in an hour.

Denis