Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jul 2019 12:57:12 -0400
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 3/4] irqchip: ingenic: Get virq number from IRQ domain
To:     Marc Zyngier <marc.zyngier@arm.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        linux-kernel@vger.kernel.org, od@zcrc.me,
        Zhou Yanjie <zhouyanjie@zoho.com>
Message-Id: <1564419432.1759.0@crapouillou.net>
In-Reply-To: <538e79e5-539b-3066-b662-8ed4ec8bf261@arm.com>
References: <20190727191741.30317-1-paul@crapouillou.net>
        <20190727191741.30317-3-paul@crapouillou.net>
        <538e79e5-539b-3066-b662-8ed4ec8bf261@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Marc,


Le lun. 29 juil. 2019 =E0 6:38, Marc Zyngier <marc.zyngier@arm.com> a=20
=E9crit :
> [+ Zhou Yanjie]
>=20
> Paul,
>=20
> On 27/07/2019 20:17, Paul Cercueil wrote:
>>  Get the virq number from the IRQ domain instead of calculating it=20
>> from
>>  the hardcoded irq base.
>>=20
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  ---
>>   drivers/irqchip/irq-ingenic.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>=20
>>  diff --git a/drivers/irqchip/irq-ingenic.c=20
>> b/drivers/irqchip/irq-ingenic.c
>>  index d97a3a500249..82a079fa3a3d 100644
>>  --- a/drivers/irqchip/irq-ingenic.c
>>  +++ b/drivers/irqchip/irq-ingenic.c
>>  @@ -21,6 +21,7 @@
>>=20
>>   struct ingenic_intc_data {
>>   	void __iomem *base;
>>  +	struct irq_domain *domain;
>>   	unsigned num_chips;
>>   };
>>=20
>>  @@ -34,6 +35,7 @@ struct ingenic_intc_data {
>>   static irqreturn_t intc_cascade(int irq, void *data)
>>   {
>>   	struct ingenic_intc_data *intc =3D irq_get_handler_data(irq);
>>  +	struct irq_domain *domain =3D intc->domain;
>>   	uint32_t irq_reg;
>>   	unsigned i;
>>=20
>>  @@ -43,7 +45,8 @@ static irqreturn_t intc_cascade(int irq, void=20
>> *data)
>>   		if (!irq_reg)
>>   			continue;
>>=20
>>  -		generic_handle_irq(__fls(irq_reg) + (i * 32) + JZ4740_IRQ_BASE);
>>  +		irq =3D irq_find_mapping(domain, __fls(irq_reg) + (i * 32));
>>  +		generic_handle_irq(irq);
>>   	}
>>=20
>>   	return IRQ_HANDLED;
>>  @@ -95,6 +98,8 @@ static int __init ingenic_intc_of_init(struct=20
>> device_node *node,
>>   		goto out_unmap_base;
>>   	}
>>=20
>>  +	intc->domain =3D domain;
>>  +
>>   	for (i =3D 0; i < num_chips; i++) {
>>   		/* Mask all irqs */
>>   		writel(0xffffffff, intc->base + (i * CHIP_SIZE) +
>>=20
>=20
> This is likely to conflict with this[1] series, which turns the
> intc_cascade function into a chained handler (which it should have=20
> been
> from the start). Can you please work with Zhou to post a unified=20
> series?
>=20
> Having two people working independently on the same file is likely to
> end badly otherwise.

I'm registered as maintainer for Ingenic SoCs (including ingenic-irq.c)
and Zhou didn't Cc me on his patchset... And if he did I'd have a few
comments on his patches that would have to be addressed in a V5.

If you think my patchset is fine, then maybe merge it then Zhou can just
rebase on top?

Cheers,
-Paul

> Thanks,
>=20
> 	M.
>=20
> [1]
> https://lore.kernel.org/lkml/1564335273-22931-1-git-send-email-zhouyanjie=
@zoho.com/
> --
> Jazz is not dead. It just smells funny...

=