Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3665186ybi; Mon, 29 Jul 2019 10:22:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqw+q+NOyvy3hAP82sH4dF6QjfZUCZ37/FGYdt9Z5lo2ihG/In4UdPh2R9QhQVRrxt1DPHMy X-Received: by 2002:a17:902:543:: with SMTP id 61mr110896399plf.20.1564420956026; Mon, 29 Jul 2019 10:22:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564420956; cv=none; d=google.com; s=arc-20160816; b=jNGtXlie1/HdEgOoLE0Iges461PkpccLln0gVfDnHhKJJcBzQQ3vDB54hJPyq2GwpP Q7TrNqpsBB9Vdh/RqVFvwp5hL13YgarkoaMpb746DrUtb1xLAj7Gw504jmoWO4dBHUI8 IQFv1O12VzknCO4ukAmWQic91knwmBOdQPRx5ZlSAD+YYCvYh1pSZzZhLlOty3NAaeh5 BtBkaaRasl2z1Iv6E3mAnTTULvqA35csUdVU/cJDR0MeJzcbW5X9upCgBnGwuGa3QEJ5 tsndt6uhDuc5OSA4BWr1NJ70J7qy4rys0O93fXKqUaK/csvJtxIhrQ6u3Mt3zufuNxgw ModA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eCe5UdCCrRAnfKH0qXJky7MR35LroaSGbIbWnmVl4e4=; b=dPPeuIPHcRUfAp1ch5B7KheNyAqCEKpkIPWLRK6yWb1/ezOg9t4qyt3kSA2bbohsje 49iqATUhTBBTf1teoJdiCqCWNoKlZ991C/gjMwGY5hc381UzLAglo23/Zz3ud3yK7Wdf cKscOacvyH2QaJKH4IWucpCqkzfi7ulRORYGPqsXl/nWuqjTEoV2u8snZX5dy3+sKLTP fcWooeaH1DSR4MRju821EvbCX0AW1V4b5l9I+1UZNk9MG2U8d+/srng6qj8NEj1jhMqp FYvJqeWKTod0Fr9PqQg8994llMCmj20lXcWP5+uYaTrSNxzL/DBbfpH0oUYYBUvjGzlQ kA0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x18si28660994plm.292.2019.07.29.10.22.21; Mon, 29 Jul 2019 10:22:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727582AbfG2Mym (ORCPT + 99 others); Mon, 29 Jul 2019 08:54:42 -0400 Received: from foss.arm.com ([217.140.110.172]:43716 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727067AbfG2Mym (ORCPT ); Mon, 29 Jul 2019 08:54:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 86D1A28; Mon, 29 Jul 2019 05:54:41 -0700 (PDT) Received: from e119884-lin.cambridge.arm.com (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9656B3F71F; Mon, 29 Jul 2019 05:54:39 -0700 (PDT) From: Vincenzo Frascino To: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, salyzyn@android.com, pcc@google.com, 0x7f454c46@gmail.com, linux@rasmusvillemoes.dk, sthotton@marvell.com, andre.przywara@arm.com, luto@kernel.org, Matteo Croce Subject: [PATCH] arm64: vdso: Fix Makefile regression Date: Mon, 29 Jul 2019 13:54:21 +0100 Message-Id: <20190729125421.32482-1-vincenzo.frascino@arm.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using an old .config in combination with "make oldconfig" can cause an incorrect detection of the compat compiler: $ grep CROSS_COMPILE_COMPAT .config CONFIG_CROSS_COMPILE_COMPAT_VDSO="" $ make oldconfig && make arch/arm64/Makefile:58: gcc not found, check CROSS_COMPILE_COMPAT. Stop. Accordingly to the section 7.2 of the GNU Make manual "Syntax of Conditionals", "When the value results from complex expansions of variables and functions, expansions you would consider empty may actually contain whitespace characters and thus are not seen as empty. However, you can use the strip function to avoid interpreting whitespace as a non-empty value." Fix the issue adding strip to the CROSS_COMPILE_COMPAT string evaluation. Cc: Will Deacon Cc: Catalin Marinas Reported-by: Matteo Croce Signed-off-by: Vincenzo Frascino --- arch/arm64/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index bb1f1dbb34e8..61de992bbea3 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -52,7 +52,7 @@ ifeq ($(CONFIG_GENERIC_COMPAT_VDSO), y) ifeq ($(CONFIG_CC_IS_CLANG), y) $(warning CROSS_COMPILE_COMPAT is clang, the compat vDSO will not be built) - else ifeq ($(CROSS_COMPILE_COMPAT),) + else ifeq ($(strip $(CROSS_COMPILE_COMPAT)),) $(warning CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will not be built) else ifeq ($(shell which $(CROSS_COMPILE_COMPAT)gcc 2> /dev/null),) $(error $(CROSS_COMPILE_COMPAT)gcc not found, check CROSS_COMPILE_COMPAT) -- 2.22.0