Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3778952ybi; Mon, 29 Jul 2019 12:27:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXXLXhoTMxpCLCK+5/JWdXvbdgfoSF8op7fRWu0sWe8WIgy3LE2hj20mvKsqhiIg3IZWCB X-Received: by 2002:a17:902:f204:: with SMTP id gn4mr112706700plb.3.1564428472636; Mon, 29 Jul 2019 12:27:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564428472; cv=none; d=google.com; s=arc-20160816; b=fAp2Kgtv0CGiBgx7AcvE00Z6PvOGftwNyc9Wz6CbdO83PwiPCkBWjUsdokEFvwKCxy 3UQt6PCUnKyAXeISyG+Z0zXCuiO0OWGQsMdkhAGo2nD50c2ky+7ZV+3wY8d9A9uGHPUC HwrZaVe3DYSew7qUlgg/OjJqSVGQv9Akt41Z+oj/Ut2zhPwgDJYURqCxHhvABaaPS+Wy XeofiXJ6HC3g2/2dAPZk1GlSXugnIoRdoUnghBijlHqChaAo188KcON/NtRyXX0UXMt7 UjO2KF9nWTCkBI6d+o1+wgWRldSWmnt8IkfiaIhfK6fRUfDTwl48oQe3vJktVUnxJNXh Jh9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1gop2WQakw39EVmEG3HQ5R3ia+tj0ahEugcn6D7gzBs=; b=XmJ4mPtUuf4KLFHnRrEry1HB0+cHZlYNcpmV5dZk+AfMfkIJGf1Hq0W07gIiAD+9Bl Lk81ecLb1JWp1RjkxNsTwgV5lsWVkYU+yJHydvQ2ci1UBOEqSv+HoakOdHOZV6SWdwap HYsAShP6KNDKeoI94N2gTJQukBkr/VYsTAZRKpb7UsFDQTa17rlGOq+j4fMo+CwFg0pB 6LDSIEL+HhqA4thWznRa0FMLtAj6kI1G+jcMzZFRg7bXvlNQcqMGHEMnaPQ555TTjzfz ga3IKPH+oNjRmIqiJQZtO4guyC5NFRql1P/puJYXr04tn6ubTqUSAMbnqNWEeSgvYaLR GeLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RIMq7lbW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bf7si25694677plb.216.2019.07.29.12.27.37; Mon, 29 Jul 2019 12:27:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RIMq7lbW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728885AbfG2R0X (ORCPT + 99 others); Mon, 29 Jul 2019 13:26:23 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:43724 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfG2R0W (ORCPT ); Mon, 29 Jul 2019 13:26:22 -0400 Received: by mail-io1-f65.google.com with SMTP id k20so121758338ios.10; Mon, 29 Jul 2019 10:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1gop2WQakw39EVmEG3HQ5R3ia+tj0ahEugcn6D7gzBs=; b=RIMq7lbWoqJyQm8c7nRO9/Zk71C3qWZ97+yIYo6C/GaFfvgX68BC+TNK4BgfE37czl kpca1j6v8gKHHFwI/ZpDqRm00VtMLV8vvOvCJ8BCaSZZpycocrn7osdEFw0e72CaSZCy XOkDTm2D2xzP6P7+k/CbPSPjR9qwE0eatRTzp2oIF88zR2G90oaY7EEtD7oFJOav2WpK fUF2i/EbVmtpvEeCagmV8kJUWPXTCTJ9CYP0O+q1/DlnkHu5u9njlUc+6U0XroxpXETm 78uBfiOFvQqLiTlURK9BwQ3ErOT6uvN0Lcm8izTARFdhvj0W3ArcDah9eZEZ10vG3Io5 a+8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1gop2WQakw39EVmEG3HQ5R3ia+tj0ahEugcn6D7gzBs=; b=eaP5we1XMztkH3JUSr+DYmRnhI489glKHf8gxyZpAmBDcR2NIufYbi4arG/E3WNuWr UjzW9mZJs025uuUWihptropfJHCAulxo0A/FFrC79KxzRku3nA1MoFi84JHVTE5jI8wL usfS56kWyOzJS2ye4Af1CrP+L9gLgDPRDQttorvSEuDVikoH4AbSs6rgy71WvP58vPjC JkZlSFnm1mlfQvwk/kLSNr7qV4DHyLW0SrIZDSWWp7fvYcRxTBZRlVLHFtDlpgZmhi+A 8QWKVK/GTeuLVlBRyDOzL7pfOtUmTKUz3FfTlRaXJm65+b44QjOfsr4EGfPxWZYvfnbc s/0A== X-Gm-Message-State: APjAAAU/IeVfZiUaByl7x23HcLqXuYQ+0Reuv8GUYrrrzxHJQI6m92Ws T1kPtxtPQMweNDOerAVUrZ4= X-Received: by 2002:a5d:9291:: with SMTP id s17mr16425770iom.10.1564421181746; Mon, 29 Jul 2019 10:26:21 -0700 (PDT) Received: from localhost ([8.46.76.96]) by smtp.gmail.com with ESMTPSA id p10sm78171880iob.54.2019.07.29.10.26.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jul 2019 10:26:21 -0700 (PDT) Date: Mon, 29 Jul 2019 19:26:07 +0200 From: Dmitry Torokhov To: "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH 1/2] input: keyboard: gpio_keys_polled: use gpio lookup table Message-ID: <20190729172607.GB755@penguin> References: <1564415994-22871-1-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1564415994-22871-1-git-send-email-info@metux.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enrico, On Mon, Jul 29, 2019 at 05:59:53PM +0200, Enrico Weigelt, metux IT consult wrote: > From: Enrico Weigelt > > Support the recently introduced gpio lookup tables for > attaching to gpio lines. So, harcoded gpio numbers aren't > needed anymore. > > changes v3: > * fix printf string in gpio_keys_polled_get_gpiod() > * fix unused variable 'error' in gpio_keys_polled_get_gpiod() > * fix uninitialized variable in gpio_keys_polled_get_gpiod_fwnode() As I think I mentioned a while back I would prefer to get gpiolob support swnode-backed properties so that the driver would not need to know about differences between ACPI, DT and static board files. I just recently re-posted patches for this, let's see if we can get them landed in the kernel. Thanks. -- Dmitry