Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3783744ybi; Mon, 29 Jul 2019 12:33:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZaXwk77EhGJ2jO7JTN96PXrtt4sKnXGI5XTVW88eNV2mdGMkYFcxdKgfjZmI3LTxL16Bx X-Received: by 2002:a63:d301:: with SMTP id b1mr97784522pgg.379.1564428782264; Mon, 29 Jul 2019 12:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564428782; cv=none; d=google.com; s=arc-20160816; b=NzwXG5t93KZZI+Z4ahzL2nIoVFGe2l1dZ+IU/eWuXLpWQ1Wdi0dFdcdNH06ykwjsqX BAJicDvZmRdg+U1uOkg3Xarj/bysXBtCvYKiNo4o2Ogj+Dzp++rNILu/idsVYjOgmzeY izy0o19MfqLB/jph0nGaFrE7uzUXjq7/cz8twph7ZVlDoIOVXMg5LZjoIsR0OXIgoORJ P6yVuL4cDBrnb8d46cXz5c+egOVK3NB3/k5gYZ9dc2YrKuAkwxJ4p/bKeXTKBHEVcIk+ o4kZAUmCwKiFEyop20bkAFuq13cCgD59B9M2retSBgICI3rRTEJaiG6Y0+q/jakHqlbC h+zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3YSiCVwi/t3Cfve664Szudf58X3z/TMZYt8XNDFMUfc=; b=hqqnq5pVk0dQyYbkqE6y/jwOw0wZKf0yfBpA/Hcb2rt1jslVlXEMMRZe8EYsh061bC FXUh5/yaJw8b4PPGLjFq6VO0rx3HHhOsIx2ffDP5Kdw4MNKPFRePaskVD2B5idf3FRq8 GSCmn1Jk3nA/vwkxWZYYDoZc4I5Y3S2q/jEOVXZJCgHfI4ubjnMYN+AM53II7MUOyvIR ZzQY9LkFDcWNdQLzXsoSGggI3gRb1jYLFHoCc6Mwx+8lIMd89wI+MUl4etJHY77eUyzQ wD4fM/YiJ31a+v7OQkvA7Wi1e9TxzmNIBeDYV8qlQcKwJ0wdRO7eFa7uNBitE0BW4MpC 3E1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mf6oueWB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 124si28060473pgb.11.2019.07.29.12.32.46; Mon, 29 Jul 2019 12:33:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mf6oueWB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729906AbfG2T13 (ORCPT + 99 others); Mon, 29 Jul 2019 15:27:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:40026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727835AbfG2T1Y (ORCPT ); Mon, 29 Jul 2019 15:27:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E3DA21655; Mon, 29 Jul 2019 19:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428443; bh=LXM8VJBQi1iN73pSbp6UozmuKSPd1Mh6D0Wfx/2GxcE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mf6oueWBiDvaqetG/7sw/QiELbRPOuD6sFuE6WagrFCXUbsioqNG45q0D2ktsso4I KZiKIXMgvvmfMPlH/xCi1KmRMcY4NY7HcrqFI9wsihDE0trywseIH7eQZgZn8j8VnN 02XR2eFtMZob2/HqQQfMRa9mObXhbENhOESpP+do= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqing Pan , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 078/293] ath10k: fix PCIE device wake up failed Date: Mon, 29 Jul 2019 21:19:29 +0200 Message-Id: <20190729190830.601225249@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 011d4111c8c602ea829fa4917af1818eb0500a90 ] Observed PCIE device wake up failed after ~120 iterations of soft-reboot test. The error message is "ath10k_pci 0000:01:00.0: failed to wake up device : -110" The call trace as below: ath10k_pci_probe -> ath10k_pci_force_wake -> ath10k_pci_wake_wait -> ath10k_pci_is_awake Once trigger the device to wake up, we will continuously check the RTC state until it returns RTC_STATE_V_ON or timeout. But for QCA99x0 chips, we use wrong value for RTC_STATE_V_ON. Occasionally, we get 0x7 on the fist read, we thought as a failure case, but actually is the right value, also verified with the spec. So fix the issue by changing RTC_STATE_V_ON from 0x5 to 0x7, passed ~2000 iterations. Tested HW: QCA9984 Signed-off-by: Miaoqing Pan Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c index a860691d635d..e96534cd3d8b 100644 --- a/drivers/net/wireless/ath/ath10k/hw.c +++ b/drivers/net/wireless/ath/ath10k/hw.c @@ -168,7 +168,7 @@ const struct ath10k_hw_values qca6174_values = { }; const struct ath10k_hw_values qca99x0_values = { - .rtc_state_val_on = 5, + .rtc_state_val_on = 7, .ce_count = 12, .msi_assign_ce_max = 12, .num_target_ce_config_wlan = 10, -- 2.20.1