Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3788956ybi; Mon, 29 Jul 2019 12:38:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIVMJroqaFvFSuQPTDm0qKmiVGk9LxgjyQfh2ZX00h/axkX4LsqF3Hn+/eTPS3mK4xFYoi X-Received: by 2002:a17:902:2f84:: with SMTP id t4mr107986861plb.57.1564429135308; Mon, 29 Jul 2019 12:38:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564429135; cv=none; d=google.com; s=arc-20160816; b=mvn9HazwTf57bNWX2yGgQf94wAAYlsGu/EB4mtt8R1lFbKPtLUasOzMgkllOEqNkW+ VpFBGqo4NbFK8HhXVvemLx3kkeHpTxEgRKed/XfitnA2P4IUH7GpZ4O9hgN8SJvO2Jpj ezha0Q7kM2cdXgQaYoNYHG0t/UVtxfHMCRToYFN6iddqSULJMfkEM380gstZS3YsKmue d728p3XsR+IV0WKFJPEZBZcy1Gxt57ZG8/+4co58JDHjBD4ymgf1HeeTV5xKarx+v4kK 7BNK3kyjhEF7t+rGlH7Ds4U4eWnhfk6luhjEmLh5La2EcRQqCaSzjZE/AhmMmWplqQZu XDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xjc7aDGiN1o6ddryfgVpPWuxg4reRdjxt87ntK6pwnk=; b=kbLA2e2RQU3VZv0TBN6gQKxfwPi2YB6jNQWsH/l8Q+3jhZgZkLaiBMDY7RTrU8dfX1 b+z8dFuwF4vtOYSMzjo7Tt4VGSKt8aj7TSYiREGrRh/Go3NNuIWMPZKhPBd4yCCec7ij hU2LXvI8nF1Yb1fjKvFuOX0iweH0P3ND9dLm7OAIdoveQgVWUJUHfhCJnfvdkWbloKNc V6GPLTk72/+tR1/hKVwqpGpn4a5u+FAbgYaIKPai0xpxFtq+F6d6movo54yXEfbD+QNz tSc/iBsVegquvPs6g0+9/l1+C5eXmRg8R215HlztGk0MDY1zNymKxnfeROHX9jjeJ+aj yTfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gskMl46c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si3923076pgp.390.2019.07.29.12.38.35; Mon, 29 Jul 2019 12:38:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gskMl46c; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730007AbfG2Tgi (ORCPT + 99 others); Mon, 29 Jul 2019 15:36:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:51000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbfG2Tgg (ORCPT ); Mon, 29 Jul 2019 15:36:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 182D3217D9; Mon, 29 Jul 2019 19:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428995; bh=bnNHVAa7cAU1dHs9mWMLdFPLJdL5nPw/dd6t3e9ifqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gskMl46cvMCLuDukA5g3SNsywHb+/RXDhUfRWigtbg3tAs1Y8slESdm0gTklqGo7D Ua86g/Ny+8aFmxPBeEZ+6fM2h6FIOlAilEdKck4UvOWtkWSMDC+MQOhL/J8tb8d0iv 8W2RLYKsMCLtpq+vOTID9xvF2YLxaJqsyAne/hC8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robert Hancock , Lee Jones , Sasha Levin Subject: [PATCH 4.14 251/293] mfd: core: Set fwnode for created devices Date: Mon, 29 Jul 2019 21:22:22 +0200 Message-Id: <20190729190843.674050931@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c176c6d7e932662668bcaec2d763657096589d85 ] The logic for setting the of_node on devices created by mfd did not set the fwnode pointer to match, which caused fwnode-based APIs to malfunction on these devices since the fwnode pointer was null. Fix this. Signed-off-by: Robert Hancock Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index c57e407020f1..5c8ed2150c8b 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -179,6 +179,7 @@ static int mfd_add_device(struct device *parent, int id, for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { pdev->dev.of_node = np; + pdev->dev.fwnode = &np->fwnode; break; } } -- 2.20.1