Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3798925ybi; Mon, 29 Jul 2019 12:51:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXceD0E+4r/3oYNmtrwzYrxk8Cx7EdrbErtIi6jgwrotTaQ5IYvJeTzdsEYw3FVTDWgAkY X-Received: by 2002:a62:6d84:: with SMTP id i126mr37444883pfc.129.1564429881175; Mon, 29 Jul 2019 12:51:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564429881; cv=none; d=google.com; s=arc-20160816; b=VIjU0NO5cw/kTfATkK+qYLI05UDILNltHYhEHqleGgZcmKWO2AT+scPaKi9NbRmidz Rtuh8Swk1hAJu1XnZCexnDHkC9r/V8MWtlCh4/qCLwZLm3Y9jbgg7dca6uhGF7tnCTV1 KQJw+uCQLyWC6Ky0FUMBOzZ7LkjQFEWWNJPXlGWizxWMz7lyF6GezP9Q3J+dzhJ61Ull 8vv2SI2TvkPorP8TmpDsif938kJg6TcT0dxM/Y3aKXms4gQNvEytEC1GRCNNVkQP0vom EL4dlZ1PsKuL/rSj0Az3PmRodFSiV7erbwa8ozpXmWbKoh/8i37nAhcVowZJCUcfS3z0 gwhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EeLjhj3iAakjnhfH6dg/IRBHT51SNW9xdx73gr+i1i8=; b=f0F/qyvTJYFE/NSsrxr6Xt6nCEkv2twDHnwhWHx4m3FCnJ/IYvqn0rVVbIMkHlN+F6 CGFm8iplYK0xIERZuILGtTwSlE/cIVondK+HsPseF/hnE0UsmME17UyrPW6ZV66Lq/oD Xiikmx7w0birLHNzNbO5yqX3Wg70qd3OezyzG933hI36Xvl9aW9hk7WLemlj7UYcazS6 gyeypJNXZEFdAp/v/ZSfbLD64NR0HFXwKzuooBbS63OrKl+gj+F3yp5SSrzLo2QML5rT e97Ej7sDqlu9YZrL/lFBiCsC1ovWyPutGZNq8PWhCUXNnBD/+PNX2PFMPj3Txod6ItKr FkyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUUUTcw4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u70si25415474pgd.1.2019.07.29.12.51.06; Mon, 29 Jul 2019 12:51:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUUUTcw4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390609AbfG2Ttz (ORCPT + 99 others); Mon, 29 Jul 2019 15:49:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:40640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389663AbfG2Ttx (ORCPT ); Mon, 29 Jul 2019 15:49:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95C1F20C01; Mon, 29 Jul 2019 19:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564429793; bh=iGLTYcg7MHp54Z214a/0pOg/Ych1HsdY6+VgfTAb9ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iUUUTcw4nHgEZndWdJ0Qrc74XyqCT5SKM+LAEyoS+aoF1oh2DiiIeodHhugPPap8H cXVsQqfWy6R5e3tFedjev+Pil1ghz2/H03ax3Nx5N3y1WSWFuKYklguu7d1u51e1/v K9EZvGCQrooMCXb42TKNZIdaZwtM2jmhFDs29PSQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robert Hancock , Lee Jones , Sasha Levin Subject: [PATCH 5.2 097/215] mfd: core: Set fwnode for created devices Date: Mon, 29 Jul 2019 21:21:33 +0200 Message-Id: <20190729190755.972598216@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190739.971253303@linuxfoundation.org> References: <20190729190739.971253303@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c176c6d7e932662668bcaec2d763657096589d85 ] The logic for setting the of_node on devices created by mfd did not set the fwnode pointer to match, which caused fwnode-based APIs to malfunction on these devices since the fwnode pointer was null. Fix this. Signed-off-by: Robert Hancock Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index dbf684c4ebfb..23276a80e3b4 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -175,6 +175,7 @@ static int mfd_add_device(struct device *parent, int id, for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { pdev->dev.of_node = np; + pdev->dev.fwnode = &np->fwnode; break; } } -- 2.20.1