Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750741AbVLHOJN (ORCPT ); Thu, 8 Dec 2005 09:09:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751186AbVLHOJN (ORCPT ); Thu, 8 Dec 2005 09:09:13 -0500 Received: from clock-tower.bc.nu ([81.2.110.250]:43223 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S1750741AbVLHOJM (ORCPT ); Thu, 8 Dec 2005 09:09:12 -0500 Subject: Re: [ACPI] Re: RFC: ACPI/scsi/libata integration and hotswap From: Alan Cox To: Jeff Garzik Cc: Matthew Garrett , Christoph Hellwig , randy_d_dunlap@linux.intel.com, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net In-Reply-To: <20051208135225.GA13122@havoc.gtf.org> References: <20051208030242.GA19923@srcf.ucam.org> <20051208091542.GA9538@infradead.org> <20051208132657.GA21529@srcf.ucam.org> <20051208133308.GA13267@infradead.org> <20051208133945.GA21633@srcf.ucam.org> <20051208135225.GA13122@havoc.gtf.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Thu, 08 Dec 2005 14:07:43 +0000 Message-Id: <1134050863.17102.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 29 On Iau, 2005-12-08 at 08:52 -0500, Jeff Garzik wrote: > On Thu, Dec 08, 2005 at 01:39:45PM +0000, Matthew Garrett wrote: > > On Thu, Dec 08, 2005 at 01:33:08PM +0000, Christoph Hellwig wrote: > > > > > Don't do it at all. We don't need to fuck up every layer and driver for > > > intels braindamage. > > > > Doing SATA suspend/resume properly on x86 depends on knowing the ACPI > > object that corresponds to a host or target. > > Not true. Actually he is right. You have to know the ACPI object in order to run the _GTM/_STM etc functions. If you don't run those your suspend/resume may not work, may corrupt and so on. The only safe alternative is to disable acpi which, while it would have been a good idea before the spec ever got out, is a bit late now. If you don't run the resume methods your disk subsystem status after a resume is simply undefined and unsafe. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/