Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 29 Jul 2019 22:05:57 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Rik van Riel <riel@surriel.com>
Cc:     linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
        dietmar.eggemann@arm.com, mingo@redhat.com,
        morten.rasmussen@arm.com, tglx@linutronix.de,
        mgorman@techsingularity.net, vincent.guittot@linaro.org
Subject: Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum
 of task_h_load
Message-ID: <20190729200557.GR31398@hirez.programming.kicks-ass.net>
References: <20190722173348.9241-1-riel@surriel.com>
 <20190722173348.9241-4-riel@surriel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190722173348.9241-4-riel@surriel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote:
> @@ -3012,25 +2983,24 @@ static inline int throttled_hierarchy(struct cfs_rq *cfs_rq);
>  static void update_cfs_group(struct sched_entity *se)
>  {
>  	struct cfs_rq *gcfs_rq = group_cfs_rq(se);
> -	long shares, runnable;
> +	long shares;
>  
> -	if (!gcfs_rq)
> +	if (!gcfs_rq) {
> +		update_runnable_load_avg(se);
>  		return;
> +	}
>  
>  	if (throttled_hierarchy(gcfs_rq))
>  		return;
>  
>  #ifndef CONFIG_SMP
> -	runnable = shares = READ_ONCE(gcfs_rq->tg->shares);
> -
>  	if (likely(se->load.weight == shares))

I'm thinking this uses @shares uninitialized...

>  		return;
>  #else
>  	shares   = calc_group_shares(gcfs_rq);
> -	runnable = calc_group_runnable(gcfs_rq, shares);
>  #endif
>  
> -	reweight_entity(cfs_rq_of(se), se, shares, runnable);
> +	reweight_entity(cfs_rq_of(se), se, shares);
>  }