Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3817049ybi; Mon, 29 Jul 2019 13:12:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOO96UZdN6ZrHnK+qciwdQG070pYGnWssdze+dotDqDCcSNzloVTYVki3nEKibNAx7t05t X-Received: by 2002:aa7:9dcd:: with SMTP id g13mr39166771pfq.204.1564431123682; Mon, 29 Jul 2019 13:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564431123; cv=none; d=google.com; s=arc-20160816; b=FYRp0fE5Q95PkmLOc0eQswuRhlW/2T82Mt09l3DurpwuraQMLCjCh7gn+zFm5P3x7n ZIuBZVDLbWqSmDzopnUz/71rD2Wur83Ji9KRMO8cuyzOoL4QOgcn/aEBWYnXVK3e/ARy UFuJWCOEnuba/GC+ohq7YP5tGz3N5QcwIsv2svgfP4BRaHh65sbdJLNP38RJgeUmKQxT AtMljR2e+S7gAZ+sMnbxnLMjMdAu0OliasoZX16peOJbIdNe8BiYyXv1WXDY2xzL+AVB ZTKZFleREZ8n+LzYVb44joRVtVfHoXag/9dabwjQoWHY/e/06TO1OLI7HBC9i/Z5GiLZ aQVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sXa8n7FVVJVU+onXMWMMFuqyvrzMYmTU5QmvEcrHfwU=; b=WF7Yr8YE6CqT4S5AnzUoWh39MMIyKuMIpIzr+nNi09q0IbWFnmF7iGIELUsid/Fr2I q8sgvJfXfZm+7k3/3dhPjHWmIhFwm/KtGAAXvvNI+oQaRcYflwCr7OR+EBachUmhP7uG jOoiXpn6Ua25B6AggpTvJ6hJJ8J4su3Wx+/z8b8ej2Jv58RWYLaCXj2CS0AibQ75Qvk0 YT03FDMTge8JxWuT1bRyzfm6pIgAPh7NnrlKA8A72ZtmD4AZHhOX+teAA+zwlPI5TDWC JWJMRHt5/O5TkdGnUvEQPnAehIF7mBUPeCa+bPUd0m+ClPtLSz5ZNyJYlRzWEi7n/z8W Cv5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fR0aqyqr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si30038523pgi.191.2019.07.29.13.11.43; Mon, 29 Jul 2019 13:12:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fR0aqyqr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730422AbfG2UKh (ORCPT + 99 others); Mon, 29 Jul 2019 16:10:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:48646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388099AbfG2TeP (ORCPT ); Mon, 29 Jul 2019 15:34:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D9052171F; Mon, 29 Jul 2019 19:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428854; bh=0FtMzQeacx4AziLkDO6Q+rba4VKfE90ATh2vY7YtSE0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fR0aqyqrWNZN/+nMj7fKTtfPOU1v1qa0y/8Q5folA3kmz0S1RRkKDB2hsJHotYyH+ vCQIp0Vx6tPWxQWOKz2hPaSj1MRCe/QYIFjEkJZjpemWV+8e1A2xgaX1g7V8yTin96 eRCnUPLGWdMif0+NR6ittRIJZdGSYkiSyWZZ42xM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Cercueil , Linus Walleij , Paul Burton , Ralf Baechle , James Hogan , od@zcrc.me, linux-mips@vger.kernel.org Subject: [PATCH 4.14 207/293] MIPS: lb60: Fix pin mappings Date: Mon, 29 Jul 2019 21:21:38 +0200 Message-Id: <20190729190840.314387141@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Cercueil commit 1323c3b72a987de57141cabc44bf9cd83656bc70 upstream. The pin mappings introduced in commit 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers") are completely wrong. The pinctrl driver name is incorrect, and the function and group fields are swapped. Fixes: 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers") Cc: Signed-off-by: Paul Cercueil Reviewed-by: Linus Walleij Signed-off-by: Paul Burton Cc: Ralf Baechle Cc: James Hogan Cc: od@zcrc.me Cc: linux-mips@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- arch/mips/jz4740/board-qi_lb60.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) --- a/arch/mips/jz4740/board-qi_lb60.c +++ b/arch/mips/jz4740/board-qi_lb60.c @@ -456,27 +456,27 @@ static unsigned long pin_cfg_bias_disabl static struct pinctrl_map pin_map[] __initdata = { /* NAND pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-nand", - "10010000.jz4740-pinctrl", "nand", "nand-cs1"), + "10010000.pin-controller", "nand-cs1", "nand"), /* fbdev pin configuration */ PIN_MAP_MUX_GROUP("jz4740-fb", PINCTRL_STATE_DEFAULT, - "10010000.jz4740-pinctrl", "lcd", "lcd-8bit"), + "10010000.pin-controller", "lcd-8bit", "lcd"), PIN_MAP_MUX_GROUP("jz4740-fb", PINCTRL_STATE_SLEEP, - "10010000.jz4740-pinctrl", "lcd", "lcd-no-pins"), + "10010000.pin-controller", "lcd-no-pins", "lcd"), /* MMC pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "mmc", "mmc-1bit"), + "10010000.pin-controller", "mmc-1bit", "mmc"), PIN_MAP_MUX_GROUP_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "mmc", "mmc-4bit"), + "10010000.pin-controller", "mmc-4bit", "mmc"), PIN_MAP_CONFIGS_PIN_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "PD0", pin_cfg_bias_disable), + "10010000.pin-controller", "PD0", pin_cfg_bias_disable), PIN_MAP_CONFIGS_PIN_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "PD2", pin_cfg_bias_disable), + "10010000.pin-controller", "PD2", pin_cfg_bias_disable), /* PWM pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-pwm", - "10010000.jz4740-pinctrl", "pwm4", "pwm4"), + "10010000.pin-controller", "pwm4", "pwm4"), };