Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3837664ybi; Mon, 29 Jul 2019 13:37:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzI/mcI/ZSJFS6BBb0cpHf2c9o5OUB8IqR8LBt4YfkDaldznh/WD7MI8NeCT8D7Zs2rp9d6 X-Received: by 2002:a63:5f95:: with SMTP id t143mr45640170pgb.304.1564432675332; Mon, 29 Jul 2019 13:37:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564432675; cv=none; d=google.com; s=arc-20160816; b=FNweSVcHb/GN9W8CG9CAI3QR5+TKT7+q2sIXtyt6ft1tV6YFO9uwhlJKHCKFdKmkYG f3HnwLpjccIvqJ+jSx1INF344lohmBRJi9VYKYQ4D+1nTuoKwpFWaxdfFX2moVN8i0cI kbk64bjbhZ+CyDNw0XgnhupFiKz1i7BtbEtAq57v0qnb3/4cv5T4TQkRi7NA2tcMHAXI Tk+PalWzEzDak6bRn6Sv6GwQJhPIKK4IVT0HNkPG4lNCCBpiEZyclogDbRKoCZfsiYd8 CO/RzD+3o4CnNarOzZkpjmMoizlyNSNVbAwLkzLIUHGSh9thd6jurJhHs9of/j1MnVIm ehXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FooYDDFf+QXrH1X2HJ27EzsB8p/Ze/1us0sP5MjgLwA=; b=aexwm9Marg7Gk0dLQpZPtAO9htvrBFwuWuSbHeIWDpYj65dz4cQKMYhSZPkQWxmKHJ dUg3t3fOYK7Vb9vFBax13i4WFSRbmRgBjBZ/5x7s1/LU+PBhjaWfsBRa+lYk3IBsnTti 3vLfZsL8AdTQb5OIU+bcLooac6GTMOOoDQMtXEdcqRhWGJFjEEPHtppadVnKOh2t2+Id YrX5/pXADp5Um93f+IXTKqczJaqU3AANJvC7/P+mPgBoEt9NVbcvyAvIprkEH16hruJw qAVk4ZyeEwV/4WS8OcHAZTG7C1n1vjoMyBZI+EZVGePswSKf9ef12Cwpy2adklu2iNrh elDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=A5DEu5bu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z18si25454007pjt.94.2019.07.29.13.37.39; Mon, 29 Jul 2019 13:37:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=A5DEu5bu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728584AbfG2UgJ (ORCPT + 99 others); Mon, 29 Jul 2019 16:36:09 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55624 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727985AbfG2UgJ (ORCPT ); Mon, 29 Jul 2019 16:36:09 -0400 Received: by mail-wm1-f67.google.com with SMTP id a15so55039662wmj.5 for ; Mon, 29 Jul 2019 13:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FooYDDFf+QXrH1X2HJ27EzsB8p/Ze/1us0sP5MjgLwA=; b=A5DEu5buxVLitvWnebvp4Y9lHghguiQVhio58oKGyfjpXmllT17XLj/gRBHD6jusWX PAqJiU0rabGc2ISidvuOwYe1ydFs89v5x2DHR62S8dnXoRfOI6OUfY3UhDQl5Yk0nr25 Q/0HT6zQj0DrgXJ38RaZssWYzu6y3te8m0l9eMAFCe1DIgIgyVm5pN35X0lHzcL+LgA9 bR2BBO19zYhKGAMx/VMy1BI/sU7HFc+zvNBNek9IA47odqqmYxzD//dJ3JVu24Crb56V v8pVRznJOuswwoAP2HXPxr37HtdCAlnrjpx6RTBX4wO9LdlzxeSJg807BFEQk+LaibOA Vd9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FooYDDFf+QXrH1X2HJ27EzsB8p/Ze/1us0sP5MjgLwA=; b=eHByBQ4cUoq7KcOj5BwF7KQbD6MxcEnoWCHRMOEjgWlfG9gBdWQ307yRzRFsn528aM w/Lu6mnpcXrIoZWdSFCxKBOK7Aob+Z5u5iAN0WG/b/vOD+DdzxZOWSp58BtLulIt7yzL 32ehExO69APe69bkbwWrS8LgO/SIFRvLXraSmWpmSJpZNDl/Fhh4B2tqELOJXN+I1bNU ZOFv9eJbLxNOxknK5px767EAOpFbIzsm+BnPL+tFT137P+/bjkbn8Jrwf/2KHxeL6sSx 15a3J6DaAgeZ8Gort349ciEuO3GeSwbv1XRt50hqQANukUPmzNGCmnmpZZSDuuGpo8XY zq+Q== X-Gm-Message-State: APjAAAWw/DqVu5f/MPjtza6p8/QOfwMViEvyuVNZsGvTZ3ykgXataOuw 8dS+hZ9ztqr/Yz7c4UqKCsIQGJbxW0JCgS6aWZE= X-Received: by 2002:a1c:1f41:: with SMTP id f62mr102828308wmf.176.1564432567191; Mon, 29 Jul 2019 13:36:07 -0700 (PDT) MIME-Version: 1.0 References: <1563602720-113903-1-git-send-email-chengzhihao1@huawei.com> In-Reply-To: From: Richard Weinberger Date: Mon, 29 Jul 2019 22:35:55 +0200 Message-ID: Subject: Re: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps To: Zhihao Cheng Cc: Richard Weinberger , Sascha Hauer , Artem Bityutskiy , yi.zhang@huawei.com, linux-mtd@lists.infradead.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 6:51 PM Richard Weinberger wrote: > > - ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs); > > + ubifs_assert(c, p < c->lst.idx_lebs); I wonder, doesn't this assert trigger too? -- Thanks, //richard