Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <97675ac29db1339ff683bf7eacf97540b00bd2a1.camel@surriel.com>
Subject: Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum
 of task_h_load
From:   Rik van Riel <riel@surriel.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
        dietmar.eggemann@arm.com, mingo@redhat.com,
        morten.rasmussen@arm.com, tglx@linutronix.de,
        mgorman@techsingularity.net, vincent.guittot@linaro.org
Date:   Mon, 29 Jul 2019 17:13:50 -0400
In-Reply-To: <20190729200557.GR31398@hirez.programming.kicks-ass.net>
References: <20190722173348.9241-1-riel@surriel.com>
         <20190722173348.9241-4-riel@surriel.com>
         <20190729200557.GR31398@hirez.programming.kicks-ass.net>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-Me4KYEfemhtrh7ZeTQsr"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-Me4KYEfemhtrh7ZeTQsr
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2019-07-29 at 22:05 +0200, Peter Zijlstra wrote:
> On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote:
> > @@ -3012,25 +2983,24 @@ static inline int
> > throttled_hierarchy(struct cfs_rq *cfs_rq);
> >  static void update_cfs_group(struct sched_entity *se)
> >  {
> >  	struct cfs_rq *gcfs_rq =3D group_cfs_rq(se);
> > -	long shares, runnable;
> > +	long shares;
> > =20
> > -	if (!gcfs_rq)
> > +	if (!gcfs_rq) {
> > +		update_runnable_load_avg(se);
> >  		return;
> > +	}
> > =20
> >  	if (throttled_hierarchy(gcfs_rq))
> >  		return;
> > =20
> >  #ifndef CONFIG_SMP
> > -	runnable =3D shares =3D READ_ONCE(gcfs_rq->tg->shares);
> > -
> >  	if (likely(se->load.weight =3D=3D shares))
>=20
> I'm thinking this uses @shares uninitialized...

Oops indeed. Let me put the shares =3D assignment
back for the !SMP case, and edit that comment.

> >  		return;
> >  #else
> >  	shares   =3D calc_group_shares(gcfs_rq);
> > -	runnable =3D calc_group_runnable(gcfs_rq, shares);
> >  #endif
> > =20
> > -	reweight_entity(cfs_rq_of(se), se, shares, runnable);
> > +	reweight_entity(cfs_rq_of(se), se, shares);
> >  }
--=20
All Rights Reversed.

--=-Me4KYEfemhtrh7ZeTQsr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl0/YY4ACgkQznnekoTE
3oPu+QgAtD//6skWmvbZFIfUOWw/4hq1dgCOSNUon92qi/OyTFXLYFlNe+WLb00V
Oj37stqqWFnmCuVpNGKde1mfP+dW1Gbewi2N3NUHEr6CLWSFaWFAdYQPVMJEc8FF
cdVCIziMkFjZ2EXaezMRkCVQ09XN962agCiG68BGh5d77THopy7a+cDV/6dw+jjl
1V1IxeEKuWoBqVu+UJ1jjObUUtHjZOt0cosq5pvxtnAnNSPX/yBu8ZEoeWX49o5m
Yv+ihmDa+fY1tXIZ53kRzyLnsa8dPaT7q54k48qF4/6S/3ZNSN2n+CkS70bpF+Ta
IMZyz5gj8agjM3yawliTVx+hy7x27w==
=VvI1
-----END PGP SIGNATURE-----

--=-Me4KYEfemhtrh7ZeTQsr--