Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3877590ybi; Mon, 29 Jul 2019 14:27:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKDyLIssnnuwtPQ1W+yOLkIBTvCDq/71Z/7cqYcFaDbOzx+QXoVnxKqPHFtuE73HKuiwH+ X-Received: by 2002:a63:904:: with SMTP id 4mr33565825pgj.19.1564435671001; Mon, 29 Jul 2019 14:27:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564435670; cv=none; d=google.com; s=arc-20160816; b=euVGoAoF06pOlTqTmdW4xv1WsIMtX2FQG6nzBbsaqkoUF+t/oZ7HjUz/Luh9Hjct8O xDqw1qpweRcW5XqIGYleNhtBwLnHDNnkLKHiYrA6fTcCEIId0P2ChWXa5kXvhBKZG2GQ +GMErZ6QPKB+cbM+PNi9xUITZe86sNfRoGy4I1YAixRm3qoXcRjd19DlaJzt+vqtlj5F 7OW3pzHO7SowtDI+RSusI4B297bQdNc3F2+fvLYmpYgyDYrfILbLrUM43cjwwpv3mqOJ TPUa7xWnL7GUdYSFJPGJCXJwDqrgRUtYRnl4/8j5idahIuF5N+GL15K/exDqA8M6lrci z4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=e4UROmkEn8ifoxqunHEl1ezq48oKFVyKfsWKm4P+BWo=; b=a0rvlLDEmljDk8T6HB61q2ecSmcmWCgIfgfdP9e0kWHouHforfzEgPSjVeJs4istHm uoWvRbYuyNkhbN3sv8snfkZQFih47jOKalrMn/flBzlgfMF3zDtS5rIhSD0dVfs/Mgyf FPFogrUNUeoZiVi6wWb3B7QxHvhuIIA75918185HdMBeIEHIW7gy/lJJxXeYRHkVJoKp 5xJcRmAB6+/IUf9byJzVheFK38kYFKPdeHeJk+/jNS5kkNq7yfS0ojpySb3pj058jQXr XgjUUASDhRd2WLX9xuOh+l/aKK5dKjnt9C8/Gp1OhItKuTjKZ4DbJwxyCdTlwpQ8v8Y8 DZIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Aa2vh5RM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16si30398475pgj.169.2019.07.29.14.27.35; Mon, 29 Jul 2019 14:27:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Aa2vh5RM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729773AbfG2VZU (ORCPT + 99 others); Mon, 29 Jul 2019 17:25:20 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41480 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbfG2VZU (ORCPT ); Mon, 29 Jul 2019 17:25:20 -0400 Received: by mail-pg1-f194.google.com with SMTP id x15so18535419pgg.8 for ; Mon, 29 Jul 2019 14:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e4UROmkEn8ifoxqunHEl1ezq48oKFVyKfsWKm4P+BWo=; b=Aa2vh5RMfizdjhMmmlTmKp4+1DiKR0n/vsDn7XRoWN+XIEsK2lWOXPXD9TqUT9Ce56 J+ps7d7S86zJwqFA4r7B5aGKoEgoCzbCjLSqZdF4tBr8OLA6T4gD1PJTaawV+fd+axPm 2w6TagTMAIV5M9JhuF+Bl1k2AucZnS2szKD/5lACq/3/AV5UPtU5aNp89gt/e5m0delk 15FPKi3gj5jLPKMXaKdGj9KKPBBnc5Xge0tEfYVmh6MkoClXLjfh2cR+3IA64DK218wr 6Js5bDB2IZpJYonONMlhAFJt0KRNHmTOw+B/EwRRgteqRgARG4jKrfa93fU6l0Et77DM OlYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e4UROmkEn8ifoxqunHEl1ezq48oKFVyKfsWKm4P+BWo=; b=ZFNwt8kHLIynRqVwFGh38/4nMYyAsBesHcXHJrnLFJBjxB9y9c9v4Oe6XfXvH78ylw VkNoPuNrIpuPHgSiNebEjiUrEiTUf4HLNX1pmz5/yqN+GWQ0Oq+JhlQ0Rx7KVYhWcJ78 at0EiGd1NAvj5mO4NXVqBdF3JeCf+8jT+qmb6K5h5B5kMCmBVw07oWJo44CBF8BN/7X+ J/OEa3iRz8MyQYjQv9kH1itHT811OU4O8WcV9ogryyXLaCbb0+gB/mk44bjIcMbzLV6Y rjDYe6kg7CY2SkeCt2OKQlyftpw/SGq40ihniAEfvC2WGcU95J2fWF3QoHIr46IDyr2c ca+g== X-Gm-Message-State: APjAAAV+pOW6rosBeTRO5nPhdnZ+a/96jaVEgFZAi4hdEtQkXSvsPJJy 8UxSUE5UoKtuN3oG0bTTDx6us8b1VVM= X-Received: by 2002:a63:6fc9:: with SMTP id k192mr104672369pgc.20.1564435519803; Mon, 29 Jul 2019 14:25:19 -0700 (PDT) Received: from [192.168.1.188] (66.29.164.166.static.utbb.net. [66.29.164.166]) by smtp.gmail.com with ESMTPSA id t9sm64032388pji.18.2019.07.29.14.25.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jul 2019 14:25:18 -0700 (PDT) Subject: Re: [PATCH] ataflop: Mark expected switch fall-through To: "Gustavo A. R. Silva" Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook References: <20190729211053.GA6735@embeddedor> From: Jens Axboe Message-ID: <80ad9bf9-4d50-a436-586c-dd9775e3e186@kernel.dk> Date: Mon, 29 Jul 2019 15:25:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190729211053.GA6735@embeddedor> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/29/19 3:10 PM, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: m68k): > > drivers/block/ataflop.c: In function ‘fd_locked_ioctl’: > drivers/block/ataflop.c:1728:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > set_capacity(floppy->disk, MAX_DISK_SIZE * 2); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/block/ataflop.c:1729:2: note: here > case FDFMTEND: > ^~~~ Applied, thanks. -- Jens Axboe