Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4112892ybi; Mon, 29 Jul 2019 19:32:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXw+pSrvaBaphVY28PnTQP/3BmWlznFTRYIUl6YvowpQH8vEPbpDjz6EQfX3BRv4bpR1Bo X-Received: by 2002:a63:31c1:: with SMTP id x184mr103533709pgx.128.1564453957754; Mon, 29 Jul 2019 19:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564453957; cv=none; d=google.com; s=arc-20160816; b=cGQM+hCJYDBJPfpYqIl/IW3F34xVSJmb5uJNsQwdhEbfI+bgzlyYJJ08LxacjTEmDL IFiVwsthPEmCJhetHUhaKSyjyB3l1fMJ3GiBcvmUkFv1EoyxpVTeUJ8EHWbZhxmODNjC M4onuYnrfBuBsvEddrCppGzJNtNn3mMh/MpaIC6ZacZWaBu3o5E3NZjrEXNL7vv5LiVW FJTOhfh3a5PFJscIeYsdzXEYdjQoWrEnmR+G8jI3GYfLuDjHRT1OBc4UpEYe6tToOkiN Xt0y89bNlw3eTxsP/P5eK6ZWgD4KunpJRiSCHdxuQFlh3gM+gl3ncNrRRq45LzJO9v02 5PKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SQyR15TN3QPilLKSLFw9V36zCzc588UmVALWXP5mhV4=; b=lVXDHry/sKUjne+AklUYFN6LyeLziJpNFsbt/X/zXC/52RDlYZOz2IlSVQ6UjSZxow O3Y6ZLbUNDvwG561bNm0NOFiHRR7sGyvCEycnxbccBCp5fspyaitU2uJ4ULaNx2G8K/K OUlYTq1esO/YpnN3itLiIxB67QVQ04Zngf7ybaEBbAuO8LI1waxpw1B9qZ3/Zmi2CAe/ 1015/bB6zmR9wGK+DZ1m/TEWjxrZRYqa5PceqST5gm6tqwI5N0gIuMYDOmOSbhpO+4S5 BN0DVriPTyD8PxrCvcHAo63QrekXSkGItIrswmB0aabnb/QycynQESHvIU9M+5G3LZ/l 6CgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EpSsFCvt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 138si28202563pfy.77.2019.07.29.19.32.23; Mon, 29 Jul 2019 19:32:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EpSsFCvt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389734AbfG2ToC (ORCPT + 99 others); Mon, 29 Jul 2019 15:44:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:60594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389725AbfG2Tn6 (ORCPT ); Mon, 29 Jul 2019 15:43:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0363B2054F; Mon, 29 Jul 2019 19:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564429437; bh=rkS9jAr5xbZv1Y6w7MuAJaQu3AhAQDt7cEO3t9brTQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EpSsFCvtnhYmYuktXLBfzcwIx8CPOgaI+/geTscqzyTtlhXfpu5sGujGyBF3uY+a2 Vs29IyTMCRHDahNubcUWTlmD0w5wAHssYPy7UBDxkBVze6jBBpLcZ38heMUCMgx/Mu B/k3HJocXUo3bJzVhScQ80N0Xl6TbcMmQgyNSAm8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , "Peter Zijlstra (Intel)" , Andrew Morton , Bart Van Assche , Linus Torvalds , "Paul E. McKenney" , Qian Cai , Thomas Gleixner , Waiman Long , Will Deacon , Will Deacon , Yuyang Du , frederic@kernel.org, Ingo Molnar , Sasha Levin Subject: [PATCH 4.19 097/113] locking/lockdep: Hide unused class variable Date: Mon, 29 Jul 2019 21:23:04 +0200 Message-Id: <20190729190718.722179820@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190655.455345569@linuxfoundation.org> References: <20190729190655.455345569@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 68037aa78208f34bda4e5cd76c357f718b838cbb ] The usage is now hidden in an #ifdef, so we need to move the variable itself in there as well to avoid this warning: kernel/locking/lockdep_proc.c:203:21: error: unused variable 'class' [-Werror,-Wunused-variable] Signed-off-by: Arnd Bergmann Signed-off-by: Peter Zijlstra (Intel) Cc: Andrew Morton Cc: Bart Van Assche Cc: Linus Torvalds Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Qian Cai Cc: Thomas Gleixner Cc: Waiman Long Cc: Will Deacon Cc: Will Deacon Cc: Yuyang Du Cc: frederic@kernel.org Fixes: 68d41d8c94a3 ("locking/lockdep: Fix lock used or unused stats error") Link: https://lkml.kernel.org/r/20190715092809.736834-1-arnd@arndb.de Signed-off-by: Ingo Molnar Signed-off-by: Sasha Levin --- kernel/locking/lockdep_proc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c index 6cf288eef670..6fcc4650f0c4 100644 --- a/kernel/locking/lockdep_proc.c +++ b/kernel/locking/lockdep_proc.c @@ -200,7 +200,6 @@ static void lockdep_stats_debug_show(struct seq_file *m) static int lockdep_stats_show(struct seq_file *m, void *v) { - struct lock_class *class; unsigned long nr_unused = 0, nr_uncategorized = 0, nr_irq_safe = 0, nr_irq_unsafe = 0, nr_softirq_safe = 0, nr_softirq_unsafe = 0, @@ -211,6 +210,8 @@ static int lockdep_stats_show(struct seq_file *m, void *v) sum_forward_deps = 0; #ifdef CONFIG_PROVE_LOCKING + struct lock_class *class; + list_for_each_entry(class, &all_lock_classes, lock_entry) { if (class->usage_mask == 0) -- 2.20.1