Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Jul 2019 08:26:18 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Denis Efremov <efremov@linux.com>
Cc:     Masahiro Yamada <yamada.masahiro@socionext.com>,
        Michal Marek <michal.lkml@markovi.net>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] modpost: check for static EXPORT_SYMBOL* functions
Message-ID: <20190730082618.5bb5edf3@canb.auug.org.au>
In-Reply-To: <20190729141801.31333-1-efremov@linux.com>
References: <20190714152817.24693-1-efremov@linux.com>
        <20190729141801.31333-1-efremov@linux.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/W1FvA._R0XXtjhBVU9lsVnR";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/W1FvA._R0XXtjhBVU9lsVnR
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Denis,

On Mon, 29 Jul 2019 17:18:01 +0300 Denis Efremov <efremov@linux.com> wrote:
>
> This patch adds a check to warn about static EXPORT_SYMBOL* functions
> during the modpost. In most of the cases, a static symbol marked for
> exporting is an odd combination that should be fixed either by deleting
> the exporting mark or by removing the static attribute and adding the
> appropriate declaration to headers.

OK, this is now in linux-next and I am getting what look like false
positives :-(

My powerpc builds produce these:

WARNING: "ahci_em_messages" [vmlinux] is the static EXPORT_SYMBOL_GPL
WARNING: "ftrace_set_clr_event" [vmlinux] is the static EXPORT_SYMBOL_GPL
WARNING: "empty_zero_page" [vmlinux] is the static EXPORT_SYMBOL
WARNING: "jiffies" [vmlinux] is the static EXPORT_SYMBOL

empty_zero_page (at least) is not static.  It is defined in assembler ...

jiffies is defined in arch/powerpc/kernel/vmlinux.lds.S as an alias for
(part of) jiffies_64 which is not static (defined in kernel/time/timer.c).

The other 2 were OK.
--=20
Cheers,
Stephen Rothwell

--Sig_/W1FvA._R0XXtjhBVU9lsVnR
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl0/cosACgkQAVBC80lX
0GzaKwf/eMecLr6q+Z8Lqr2neg+RXHvOu+Ph+Q3hgYr0RbcLyGZYcBtE33vMZgGR
Ue3bKhTvx+0YJBg7z8uO3tP+n5BVvw/wo9Kn4s/ckWZA8eK2c3FJ2SMuT4dKir9X
bdHg+T3OVJeHT/NkHGO6TrRb/7lL/xcEwifhbG6LNc0Fdc7UQ2LIZZFeVURIWSkv
P/Q+OhS4pT1r8T7jfhVM2REMDKcl3j0/gmNjyXe4mTjaoh2rGSmfuKKnWCV0YlmT
vwBYB7zI71zH7ndRoXYoBCRWiIi0Nphgjk0idKBI/5A3UU9YZOIr5/VKfWBM7zec
SgcnFWXp+ixj6ZO2DJoWOaCq2E4b1g==
=JP8H
-----END PGP SIGNATURE-----

--Sig_/W1FvA._R0XXtjhBVU9lsVnR--