Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4221588ybi; Mon, 29 Jul 2019 21:54:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkKODaakO0nSdL5Q5cBI0mMqUfTwQM5ituL4RXVcH+gvttSbE4LytzyCuU2XDT3+dY975L X-Received: by 2002:aa7:9516:: with SMTP id b22mr39774835pfp.106.1564462477295; Mon, 29 Jul 2019 21:54:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564462477; cv=none; d=google.com; s=arc-20160816; b=qpjOBbJ6I10EfcDi4EsifrfCvNdpAP92MJb4ZivZMlO7uwj11OS+Q/q7fmGaJuxUnO JvCXzqdycg3sD1FGA41lPB7tUdyk7xkeu6HhCyciC6zzZj+2TsLEupoma79y1MZ2d9rz wwGVAunJPz1GZlxZ5W0XL5J2uQb8Wig+qL4RYOjlsciiS5A+eRelV0hG41PDZOR8LfNO Kc7J8EOZcKXGNiNuNPpsdWl1mtt9e3IXkYtDHTgnKbYk06tUzP8rnyk3VZ1Ag/PQDOmj bPnavWBTlzsPqL6wNtGeaqAsN9h+CXOk1PUKUK0yPTbDJwyeomALmRIhVcVnJ6h14doN Gn/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=QGwMAACu5i6+SiHgE5L6U1JBw4Tj1LQXdYiMXsWkkx0=; b=EhnKxjAKUY9o2ucCYHW4Pj3FYRv23yAO85Esy3d2v9zpSJ9Ey3UplSnT5STc9LCT3e X62+DizpL4S4PlkGgU+jeUsYj/nG39NimkPOY79D6uaZxvQm1/rY7/VhBwZzmp/O7ri/ 6SlSIUHKpEuH1NDnBKnlWfokX766TM9TzFEK2RWiaoVFHs4SeekEi3828atW1rhXU4wy 08CUS6VdvnHzzZSzPY7BGSpISOK5BLfAPMmFZjY7miINsyzNYg3JIHk6TX30lRyWMePe 4DYeM7jN0I1bjhtjpZIGZ3xC/eEw0o25nYxfRzHP/xNIN1+4oHEbCpYYJGc0EOXuAQQR Fn3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k73si26260930pge.353.2019.07.29.21.54.22; Mon, 29 Jul 2019 21:54:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731330AbfG3CbY (ORCPT + 99 others); Mon, 29 Jul 2019 22:31:24 -0400 Received: from inva020.nxp.com ([92.121.34.13]:45512 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730996AbfG3CbC (ORCPT ); Mon, 29 Jul 2019 22:31:02 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 55D3D1A052B; Tue, 30 Jul 2019 04:31:00 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 6EF181A0526; Tue, 30 Jul 2019 04:30:55 +0200 (CEST) Received: from titan.ap.freescale.net (TITAN.ap.freescale.net [10.192.208.233]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 2B15E4024E; Tue, 30 Jul 2019 10:30:49 +0800 (SGT) From: Anson.Huang@nxp.com To: rui.zhang@intel.com, edubezval@gmail.com, daniel.lezcano@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linux-imx@nxp.com Subject: [PATCH V3 2/5] thermal: qoriq: Fix error path of calling qoriq_tmu_register_tmu_zone fail Date: Tue, 30 Jul 2019 10:21:23 +0800 Message-Id: <20190730022126.17883-2-Anson.Huang@nxp.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20190730022126.17883-1-Anson.Huang@nxp.com> References: <20190730022126.17883-1-Anson.Huang@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anson Huang When registering tmu zone failed, the error path should be err_tmu instead of err_iomap, as iounmap() needs to be called. Signed-off-by: Anson Huang --- New patch. --- drivers/thermal/qoriq_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index 2893947..5755a11 100644 --- a/drivers/thermal/qoriq_thermal.c +++ b/drivers/thermal/qoriq_thermal.c @@ -231,7 +231,7 @@ static int qoriq_tmu_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "Failed to register sensors\n"); ret = -ENODEV; - goto err_iomap; + goto err_tmu; } return 0; -- 2.7.4