Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4396743ybi; Tue, 30 Jul 2019 01:16:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzo5AD/NAI9iMTES5HD/rzT8OSh/pz55tBl2HaKHq4NXRLfPMozvqecSwZnyRmkKPOAfqkv X-Received: by 2002:aa7:8b51:: with SMTP id i17mr41271116pfd.33.1564474607413; Tue, 30 Jul 2019 01:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564474607; cv=none; d=google.com; s=arc-20160816; b=UyRQY+B49qWre1RT1tV3Eu5JkxpAMnevUR33KfFWHU3mcjmeVm6TeaXjtHjGG0snTV 1oc8oaUjuA2hABjTU8GcSSUNo7QsMCuYBIduU5Fj5Pw1/QArXL02zaJH7IKgyRc7RatM sDvKsoVW436jJVEOFDKCREv3l/vt0plMeI3wxwlnU/dXCn6gwvHJWo/qPl3FXX0K8st3 +F2MFhrO41RPmegqrp8K2Vv4GmI8q0DPgkeXUKyvGMUNUU+LlfP09iMNmcjpeSCEQXjP KsogckoKWHdZ/7wzdHR5FTcr4RLEsqjjJf3ZohedOq2rOVhTvt/Luh9JZEJ0BjJe4gaX L1rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=j10iEndEcfl7GFmx0FBUfHkT/DIF6Lz0Je3WuUXspf4=; b=SmaFlfHt3EJTJHR4dQcVaoQNng5CVHs6FbRDZ+NGxGEhD7rAcaViyVtyt/pyrrH9T+ fe/Tc9HrOZ7ubR+5TNGyUa5lbJjK0zqomEibbnfcwG6ZYobNPdBlPUHSqb1Aw/oC39Sy 7K2X4UNX/PI9zCM5aWUnqUcDFJ6JTyK0/WsEFG0gNFtFeCClnD1EpUs9ViFs6xMdLrVC ugU5P6ydz/CJpmhJliYjq7HOGUEbNuXmv+ylhq6F1D7aYFS1g/kKBD5x6DfQZLnsgBSE OmmhjrOU40R72J83DvJSqnJfk4B66pWEtyVt1xxKK7t/Gynr8kxm2Z+VI5J/Mr2w58CU vfEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=JX9vGziM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b4si30265970pfg.49.2019.07.30.01.16.32; Tue, 30 Jul 2019 01:16:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=JX9vGziM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388781AbfG2VrQ (ORCPT + 99 others); Mon, 29 Jul 2019 17:47:16 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:44634 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727381AbfG2VrP (ORCPT ); Mon, 29 Jul 2019 17:47:15 -0400 Received: by mail-io1-f65.google.com with SMTP id s7so123297975iob.11 for ; Mon, 29 Jul 2019 14:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j10iEndEcfl7GFmx0FBUfHkT/DIF6Lz0Je3WuUXspf4=; b=JX9vGziMLV0bTzWdDEXuN2wORxj61dz7dEOXT8Y9SKYKtqwU+xD6ErVpMeRWiEzuI9 98yyj3qE8qXIZZMfgOvU/ScnBtJ2CDT7V5DT0pjTOgpoyLSl95jt69WDW0iNODp2cmw9 oF09HKKjSA6zgwa6539xg9dw/7oNc3Q6Debx/rjZCXOUFxjL/1CUBhy5gRGjz0EDELiY 9DcD3CI1ee7sVs5VlAd44Xw0XZ16251YPtko3DyygrdJoTjMekRrdWrFZ1Nb2c4cLzEf KpxJZbxyRTy9MEYf/AHlJ0Sd8kVCJIC6j3PJvb19FoT65p1ROCUKwFKE9pqk9jvoKbBq E1eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j10iEndEcfl7GFmx0FBUfHkT/DIF6Lz0Je3WuUXspf4=; b=gqhKO0WR/87Xy+kOAtDQrJUiiRyLqL1QkOi7oa9J7RfTcrd9LM10Py9tkfbclESKe0 G1zcdMNSPqiyFrvdxIDh4Mp2Io46RsuvxE15CpEu4xssST9kdHFN1G873Qb6SJ+hHBXq NQ8llgvq6vp5yuU32EPxBjQ3UR9OUXKxJMG7RqT8SZKKXOaseC7+MuPtxu52g5ak2fUo CGHW7G7otdFXaEKb936GXRXcMHGbCXkMBD8XPtZFDZhwJs3Sqxok0VG8sEHMP7tN4+Vn VYNns8pyclIbxOMp+i47NQ07XrKkdi9EbxS+vWjYdDsdMVHTjYn8V7BqSBxArc6CC74I mD4A== X-Gm-Message-State: APjAAAXU1hXxCg/lQUmP8YOuv4Okj517mTQeO7mn4Bu1H9FJgGkU1JDN fNz9giBaJGBdNQuff6B2QFeMtt4yHrOB0Khcc8BzYw== X-Received: by 2002:a5e:8c11:: with SMTP id n17mr35080222ioj.64.1564436834661; Mon, 29 Jul 2019 14:47:14 -0700 (PDT) MIME-Version: 1.0 References: <20190718194415.108476-1-matthewgarrett@google.com> <20190718194415.108476-24-matthewgarrett@google.com> In-Reply-To: <20190718194415.108476-24-matthewgarrett@google.com> From: Matthew Garrett Date: Mon, 29 Jul 2019 14:47:03 -0700 Message-ID: Subject: Re: [PATCH V36 23/29] bpf: Restrict bpf when kernel lockdown is in confidentiality mode To: James Morris Cc: LSM List , Linux Kernel Mailing List , Linux API , David Howells , Alexei Starovoitov , Network Development , Chun-Yi Lee , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 12:45 PM Matthew Garrett wrote: > bpf_read() and bpf_read_str() could potentially be abused to (eg) allow > private keys in kernel memory to be leaked. Disable them if the kernel > has been locked down in confidentiality mode. > > Suggested-by: Alexei Starovoitov > Signed-off-by: Matthew Garrett > cc: netdev@vger.kernel.org > cc: Chun-Yi Lee > cc: Alexei Starovoitov > Cc: Daniel Borkmann Any further feedback on this?