Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Jul 2019 14:37:04 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>
Cc:     PowerPC <linuxppc-dev@lists.ozlabs.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Kees Cook <keescook@chromium.org>,
        Linux kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through
Message-ID: <20190730143704.060a2606@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/WkrTSZW/7hwA8JeT.W=8kOU";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/WkrTSZW/7hwA8JeT.W=8kOU
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: powerpc):

drivers/macintosh/smu.c: In function 'smu_queue_i2c':
drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-=
Wimplicit-fallthrough=3D]
   cmd->info.devaddr &=3D 0xfe;
   ~~~~~~~~~~~~~~~~~~^~~~~~~
drivers/macintosh/smu.c:855:2: note: here
  case SMU_I2C_TRANSFER_STDSUB:
  ^~~~

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/macintosh/smu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
index 276065c888bc..23f1f41c8602 100644
--- a/drivers/macintosh/smu.c
+++ b/drivers/macintosh/smu.c
@@ -852,6 +852,7 @@ int smu_queue_i2c(struct smu_i2c_cmd *cmd)
 		break;
 	case SMU_I2C_TRANSFER_COMBINED:
 		cmd->info.devaddr &=3D 0xfe;
+		/* fall through */
 	case SMU_I2C_TRANSFER_STDSUB:
 		if (cmd->info.sublen > 3)
 			return -EINVAL;
--=20
2.22.0

--=20
Cheers,
Stephen Rothwell

--Sig_/WkrTSZW/7hwA8JeT.W=8kOU
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl0/yXAACgkQAVBC80lX
0GwhmAf/ePhS1Q79PIStbUXViKasLy26Y63miHzQp6DC0yYLAPcNySioEUZDBVuV
Pd4/3Pk/y8AKLhfuMOer8EMs7c16qY/yXKHn645SatMojhyHPR2HwYMLbNXQQip0
ziPURJty85qxE0ipdZJhWqtk5LC8kaIxXTXO4MRtzBOHHgSVOrMpv4LzIyuCxxbO
I59imbAfo5Uaf4EVlgg59yslaTKNc8Bf9LR2/E2KHez4eb4kh4G+mWk6hQ2p0lp8
zcsjrJpVJXUX/gZpngjhfMtiqr1KDQFHDCeOOAB4v6NwABvOqMDx5xN5Cs2OYi+K
/S1vr+2r9m0yvPEn80pZ8/HrBvhVvg==
=Gr+3
-----END PGP SIGNATURE-----

--Sig_/WkrTSZW/7hwA8JeT.W=8kOU--