Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190722071122.22434-1-zhang.lyra@gmail.com> <20190722071419.22535-1-zhang.lyra@gmail.com>
In-Reply-To: <20190722071419.22535-1-zhang.lyra@gmail.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Tue, 30 Jul 2019 15:18:31 +0800
Message-ID: <CAAfSe-tPVsMjmu0CoUATGRGevCpgqk999-rpfMuXqZ-V9ft7gg@mail.gmail.com>
Subject: Re: [PATCH] ARM: check stmfd instruction using right shift
To:     Russell King <linux@armlinux.org.uk>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     Lvqiang Huang <lvqiang.huang@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Gentle ping

probably this patch was missed or entered into spam?

On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
>
> From: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
>
> In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"),
> -               .word   0xe92d0000 >> 10        @ stmfd sp!, {}
> +               .word   0xe92d0000 >> 11        @ stmfd sp!, {}
> then the shift need to change to 11.
>
> Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read")
> Signed-off-by: Lvqiang Huang <Lvqiang.Huang@unisoc.com>
> Signed-off-by: Chunyan Zhang <zhang.lyra@gmail.com>
> ---
>  arch/arm/lib/backtrace.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S
> index 7d7952e..926851b 100644
> --- a/arch/arm/lib/backtrace.S
> +++ b/arch/arm/lib/backtrace.S
> @@ -70,7 +70,7 @@ for_each_frame:       tst     frame, mask             @ Check for address exceptions
>
>  1003:          ldr     r2, [sv_pc, #-4]        @ if stmfd sp!, {args} exists,
>                 ldr     r3, .Ldsi+4             @ adjust saved 'pc' back one
> -               teq     r3, r2, lsr #10         @ instruction
> +               teq     r3, r2, lsr #11         @ instruction
>                 subne   r0, sv_pc, #4           @ allow for mov
>                 subeq   r0, sv_pc, #8           @ allow for mov + stmia
>
> --
> 1.7.9.5
>