Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190729222752.GA20277@embeddedor>
In-Reply-To: <20190729222752.GA20277@embeddedor>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Tue, 30 Jul 2019 11:37:09 +0200
Message-ID: <CA+M3ks6mxV4PTWWj_0AuLcwj-SPWi85-VwXHx7iBbuo=kCPggg@mail.gmail.com>
Subject: Re: [PATCH] drm: sti: Mark expected switch fall-throughs
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Vincent Abriou <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le mar. 30 juil. 2019 =C3=A0 00:27, Gustavo A. R. Silva
<gustavo@embeddedor.com> a =C3=A9crit :
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: arm):
>
> drivers/gpu/drm/sti/sti_hdmi.c: In function =E2=80=98hdmi_audio_configure=
=E2=80=99:
> drivers/gpu/drm/sti/sti_hdmi.c:851:13: warning: this statement may fall t=
hrough [-Wimplicit-fallthrough=3D]
>    audio_cfg |=3D HDMI_AUD_CFG_CH78_VALID;
> drivers/gpu/drm/sti/sti_hdmi.c:852:2: note: here
>   case 6:
>   ^~~~
> drivers/gpu/drm/sti/sti_hdmi.c:853:13: warning: this statement may fall t=
hrough [-Wimplicit-fallthrough=3D]
>    audio_cfg |=3D HDMI_AUD_CFG_CH56_VALID;
> drivers/gpu/drm/sti/sti_hdmi.c:854:2: note: here
>   case 4:
>   ^~~~
> drivers/gpu/drm/sti/sti_hdmi.c:855:13: warning: this statement may fall t=
hrough [-Wimplicit-fallthrough=3D]
>    audio_cfg |=3D HDMI_AUD_CFG_CH34_VALID | HDMI_AUD_CFG_8CH;
> drivers/gpu/drm/sti/sti_hdmi.c:856:2: note: here
>   case 2:
>   ^~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied on drm-misc-next,

Thanks,

Benjamin

> ---
>  drivers/gpu/drm/sti/sti_hdmi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdm=
i.c
> index f03d617edc4c..1617c5098a50 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -849,10 +849,13 @@ static int hdmi_audio_configure(struct sti_hdmi *hd=
mi)
>         switch (info->channels) {
>         case 8:
>                 audio_cfg |=3D HDMI_AUD_CFG_CH78_VALID;
> +               /* fall through */
>         case 6:
>                 audio_cfg |=3D HDMI_AUD_CFG_CH56_VALID;
> +               /* fall through */
>         case 4:
>                 audio_cfg |=3D HDMI_AUD_CFG_CH34_VALID | HDMI_AUD_CFG_8CH=
;
> +               /* fall through */
>         case 2:
>                 audio_cfg |=3D HDMI_AUD_CFG_CH12_VALID;
>                 break;
> --
> 2.22.0
>