Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Jul 2019 15:56:13 +0530
From:   Bharath Vedartham <linux.bhar@gmail.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     sivanich@sgi.com, arnd@arndb.de, ira.weiny@intel.com,
        jhubbard@nvidia.com, jglisse@redhat.com,
        gregkh@linuxfoundation.org, william.kucharski@oracle.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 1/1] sgi-gru: Remove *pte_lookup functions
Message-ID: <20190730102613.GB6825@bharath12345-Inspiron-5559>
References: <1564170120-11882-1-git-send-email-linux.bhar@gmail.com>
 <1564170120-11882-2-git-send-email-linux.bhar@gmail.com>
 <20190729064842.GA3853@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190729064842.GA3853@lst.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 29, 2019 at 08:48:42AM +0200, Christoph Hellwig wrote:
> On Sat, Jul 27, 2019 at 01:12:00AM +0530, Bharath Vedartham wrote:
> > +		ret = get_user_pages_fast(vaddr, 1, write, &page);
> 
> I think you want to pass "write ? FOLL_WRITE : 0" here, as
> get_user_pages_fast takes a gup_flags argument, not a boolean
> write flag.

You are right there! I ll send another version correcting this.

Thank you
Bharath