Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4609669ybi; Tue, 30 Jul 2019 05:08:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7Y85HpIIvZNYcXSOeitQjnXPllmjZueFU3ihVtaP8hp/9QSfwHOxrMWZSMeaJpQquV7qt X-Received: by 2002:a17:902:e30d:: with SMTP id cg13mr114588569plb.173.1564488528526; Tue, 30 Jul 2019 05:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564488528; cv=none; d=google.com; s=arc-20160816; b=QMxNUk67A5plPZ5SwPI9R6+BGcnIiT992+9tuFZGcczuoIQCYBFSxUOY1V3M4kLmBq /Y5yFpR6Df4WsYVyvaXkaslRUgGDksbUehrcsdRdhtHgV5HooSSbI7IC48ek1gUJr4KB rPq+ji0pjSPZASFnr1wl5JE41AQGASnDz1GbqbKlQN8j887KOj7Md/y4DsYjciOF75rE +ULKDed3EFxwcIg7NwjNXOjAHITUkSMwHcne/4GnLvbGdfZiZSVwZhzPIuPKCTAu3bol WoUfILEK1APcOaSGsjTMSYvMKe6YIpirZPcGgx5UlLn3tX+jGCjMYrXM6T0+dTnc/iRv 2P+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8Evoy48nmtUEP14ctAQrisi69YEAvFPcmML655E68VU=; b=f7NvT7NDEkGBAYHpzFLj+FmR1oyYGf5hrNJO0C/HRhivHlvMyTPEo2epXPvXJ49rNv z8adkrn1m3FoMNvNU3bprBw07vWiNtLZbtTxDaRKyBZ7/ckm25PLD/z+hf5Q+gHhQJ9s F9Sdlczlh0FnsAgfHf73J6hUK5jXGn1b10LNZN+CpwvaqtF8N/ofZugqyUMDQYDMFogG 0lSk5HUTnelWlW4e7I745/ErCsZiVe7M8JJyJXpFk2w1Pj9xX+NiendJfV01SKzC7pwH YnVwXegsqRdFyNGO1NYcf8aYskagWRiDXkUAOXPOY3mvLUu6fg8pdoApRmpkK6CncND3 CQfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=II2UQgX8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si29609674plt.244.2019.07.30.05.08.32; Tue, 30 Jul 2019 05:08:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=II2UQgX8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729175AbfG3LCN (ORCPT + 99 others); Tue, 30 Jul 2019 07:02:13 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:56952 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfG3LCN (ORCPT ); Tue, 30 Jul 2019 07:02:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Evoy48nmtUEP14ctAQrisi69YEAvFPcmML655E68VU=; b=II2UQgX8QgyPk2rVNFmil7JY1 uB8ScT1LS9EKcqeuufjFZPGQHBCGq5NDRxZBJBaXqCQ/bj016eTD91oTWLkSHmPkt2E0CxcGMeSDz N0AdSJpiaJScXQ2RHpOC6IvlTccsnrPmLDIeRV9p5zbcqo5SCAK6EwczYqHP2xplWOv4qUo3B/G63 4dCpkKJGFvdkWcv2wNtpJJN3F6hinOlBNxC3vPVeIgvSdvZsqTAbTookueqlGysXz2k8FKBcGmf2w 7pNNW7qAA8ApAhs/2AiMWi+lKlNabz9p0vFBn+RqJzsalZBwUuJ4yYSR29yC4uI635Pns124FYkGE QRyuhmejw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:38834) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hsPtR-0004nx-SN; Tue, 30 Jul 2019 12:02:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hsPtM-00029s-Tn; Tue, 30 Jul 2019 12:02:04 +0100 Date: Tue, 30 Jul 2019 12:02:04 +0100 From: Russell King - ARM Linux admin To: Chunyan Zhang Cc: Linux ARM , Linux Kernel Mailing List , Lvqiang Huang Subject: Re: [PATCH] ARM: check stmfd instruction using right shift Message-ID: <20190730110204.GB1330@shell.armlinux.org.uk> References: <20190722071122.22434-1-zhang.lyra@gmail.com> <20190722071419.22535-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote: > Gentle ping > > probably this patch was missed or entered into spam? Please submit it to the patch system, thanks. > > On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang wrote: > > > > From: Lvqiang Huang > > > > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"), > > - .word 0xe92d0000 >> 10 @ stmfd sp!, {} > > + .word 0xe92d0000 >> 11 @ stmfd sp!, {} > > then the shift need to change to 11. > > > > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read") > > Signed-off-by: Lvqiang Huang > > Signed-off-by: Chunyan Zhang > > --- > > arch/arm/lib/backtrace.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S > > index 7d7952e..926851b 100644 > > --- a/arch/arm/lib/backtrace.S > > +++ b/arch/arm/lib/backtrace.S > > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions > > > > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists, > > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one > > - teq r3, r2, lsr #10 @ instruction > > + teq r3, r2, lsr #11 @ instruction > > subne r0, sv_pc, #4 @ allow for mov > > subeq r0, sv_pc, #8 @ allow for mov + stmia > > > > -- > > 1.7.9.5 > > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up