Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4617106ybi; Tue, 30 Jul 2019 05:15:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqww75Ykz51uOA5IcX5DQMe7u7uuPBjfMf9FR+U6YvMbg2CUL48ZjxpMRo3LGog0fXLrhKh8 X-Received: by 2002:a17:90a:5806:: with SMTP id h6mr113471800pji.126.1564488939524; Tue, 30 Jul 2019 05:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564488939; cv=none; d=google.com; s=arc-20160816; b=o0WdR2id4eu70yNimLoMleffh+O7t7ueuhffpTCfnt+3mtE4bI0DWPjPA/oh88M+Hr wZpxdZU2WfT1gx+A9Kqg17iTRDcvd3uZVzBKls/h4E9E6zFeoWNv/nBpmPbWtuiHbWKm hIa68n9dyZOvrEn35Km1l0E9lWKCx6rQ+GxV9bTcyWbja7PBxPMWwIFp0lAiVSc62kXa oHHu8N6mg4vtJ307LyJRVWY0wCJaQFv1Dn+ogYp0EJz9x5VG/k7KUFLuoyWFez7DbQ17 IPNTVma5FW4PcbuWSImUgVeMq4sZ2XhyYnKw16IUQ5sUJQp+QwCBUvJ3NiZXbH4J9X/8 OLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=75G81RZmCgjuBTX0U2d1gnw/p2hUW/tVsCG+MAkS+4M=; b=sLjlwQiBgpJ46qJ5WFvQpcG3pkX2FZ4l7TNurMQlm2f+XVY0uPGrdJxYvMhGDNB9Gm X+KRqgYz28Xzr2dyegzveWi0IaDi/L+br/RDklzIrMHw19nZLEFKyjsK6xAgHIfVnYkG rU1L8vm8lPCMitwywhzYi3fb/IMtfHTdxpU+Kj7iKKH2CgKf515iYV1q8qAXQlD2ftxy bfRIO74mkkP7fM3HEJc9nJlYv63ki6uwhlroADG0Kw/rX6Sl/nIEQh6SBJK3wnAroT58 Mtwwgf7peC1gwb61xTi4oEZX7jVG38eUzi7RG9iR8znRTrmzvjV8h/rPAdCJCajtU/70 /NGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cl14si1737994plb.341.2019.07.30.05.15.24; Tue, 30 Jul 2019 05:15:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730461AbfG3Lfg (ORCPT + 99 others); Tue, 30 Jul 2019 07:35:36 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:35318 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730368AbfG3Lfg (ORCPT ); Tue, 30 Jul 2019 07:35:36 -0400 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hsQPj-0008IG-Us; Tue, 30 Jul 2019 21:35:32 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1hsQPh-000201-KB; Tue, 30 Jul 2019 21:35:29 +1000 Date: Tue, 30 Jul 2019 21:35:29 +1000 From: Herbert Xu To: Chuhong Yuan Cc: Corentin Labbe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: tool: getstat: Fix unterminated strncpy Message-ID: <20190730113529.GB7595@gondor.apana.org.au> References: <20190730084018.26374-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190730084018.26374-1-hslester96@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 04:40:18PM +0800, Chuhong Yuan wrote: > strncpy(dest, src, strlen(src)) leads to unterminated > dest, which is dangerous. > Fix it by using strscpy. > > Signed-off-by: Chuhong Yuan > --- > tools/crypto/getstat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This file no longer exists in cryptodev. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt