Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4634296ybi; Tue, 30 Jul 2019 05:34:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwqG384GxQi6TbbEAcn9KEm7BG+iMLEEEfOlhOMoDG06ReCvo2iIN3o4HMQywu2lVsGGoY X-Received: by 2002:a17:902:347:: with SMTP id 65mr19510365pld.232.1564490068332; Tue, 30 Jul 2019 05:34:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1564490068; cv=pass; d=google.com; s=arc-20160816; b=ghfW+XuCh4PlW9iDeO+pLJK+D4U9k320e8lsXTNcQzu/8W4+cn3FlNXovDUzC0Do46 O0X08PqACIYAG+Y5Nq5QoPWstwRYBQZ26LMNnqRRusbWYKEu3IPxz0JNgr6d6qqFqL8O jB7IY0DLuKvfz/+pcAdDP6t782qKBEvVvRQVqCHGeHbuCrI1TI6KE4KPsdzHbsIzCkMY 6Rqecvq0CzjX7adBuvkV7JRP6jPfzzFGBrD3B5MyCSEIS7E6yUGLItSVeDPucNwCXRfM Jn1VUQ11bkWy3nW1MTWdNJ+nXv2nDYXCToGCgcHHfszRTVL+CBttvKFfljiq7snAu48h IJlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=dIh+Bg+Y7JR5zJCYaI23CwB6oXfe2ZfSo9J/94dn2C0=; b=vuQCg3QJVI+DddoSUvZ0qhHZnKMLuRUCIadCQWhMyYnV9Gh4IQbfX1MJlLj7B7/22/ AH+ZAFzzGWyjAFnVXAyV+ybg382Lf0LevQmpyqNUY0HU3hMe2dNDYd2mqEOYWbUnKxdp L25lHnypsNbDK2hFFFDhSrAyAFm3aSY62WJt+KThmwgMoyX92tGz4sTBLM5iuVAiqHMZ tDZKXuOgI69GuJHR6/LnzukD98/lyuopQ4A/+3vKKnKm1dDsYIivrUrVFKrTv3qHCGCB nmXQUKEHfZOesLsDtd83WzbVY786EweM0JnC2ssAoVadKz57qwzjGLXfMIdKBemR/huY eiRg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=L+PD0lzO; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17si29604188pfa.198.2019.07.30.05.34.13; Tue, 30 Jul 2019 05:34:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=L+PD0lzO; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729460AbfG3MdH (ORCPT + 99 others); Tue, 30 Jul 2019 08:33:07 -0400 Received: from mail-eopbgr70051.outbound.protection.outlook.com ([40.107.7.51]:9217 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726986AbfG3MdH (ORCPT ); Tue, 30 Jul 2019 08:33:07 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NriWVhBq1EG/g+8owiD7Blh8mf7cOyWhr6jR2/J76XU5sOSJOO9TrdAGlqTkI52AZB1/HyLG9RIF+98+G2LPE2ihiHcrio9ltSSRNveWGb5vFq0WqXKXy1YwQeTpgFolhyb108LqhlX2+eEYIdtDozcQ9pM9QRo8SgmFD7k46lfbj7ZVuXMmjd0bF3COl6Quydn2ZAjoQN7bu6eGZ0ex5w0q+XknqR8H6OGvzVxgH7ADc1ZVuTyCCaLXKFEMF7dPQ3PVuEy8AeLwPhJoKcEOCms4RLnuUL4l67za1smof3oCsA7u4ChmpeGb215NzQInrk1GEFlIBgkjxVc5rVIL2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dIh+Bg+Y7JR5zJCYaI23CwB6oXfe2ZfSo9J/94dn2C0=; b=ImLL72JQq6nLdR4wnlre96u8+YI8B++NaXIW+HIlB9bUElqtvs3F0hGsZ9dXt1LPqHHO+I2xDmz1nvE1tm4EmblSd55F+I6Gn32FUq75u9Xu+lxL54pbs61JoGXsSrou+XJmYrpSrmioFSoA8WIE7WtRY3iCBrN2EEJpDV81AIa4GW4JuAXvVoaT0ZnqB+3aS9CwQaPpzl5kBu+rNMMBQuN8MM0TmjQsJRbdNOdUP1UrnSVq6IQSxvwQn/mnXOaGETHMgASjgsJn+h9x0qUQ7/wOEH+4nSUhDDCyVj2ROin+K72UyaMsxP177N0Iq0wm1UU2uYUUupCuI1//iSkbgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dIh+Bg+Y7JR5zJCYaI23CwB6oXfe2ZfSo9J/94dn2C0=; b=L+PD0lzOlrIv+mTDx/nh9p6/H5db2n3sbrfekUrPBizneQi/ck1kAaq8qKUn6stJjJEkBmx6nOMdHq1j1ayzMucOsxY+LX/FP2qpRYKtelys4vS4Sz8lldxLibXLLby6sfLeCy7jt+WpGDc1Y579+1VUwY406YTCy/0zeE4PKdE= Received: from VI1PR05MB4141.eurprd05.prod.outlook.com (10.171.182.144) by VI1PR05MB5568.eurprd05.prod.outlook.com (20.177.202.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.13; Tue, 30 Jul 2019 12:33:02 +0000 Received: from VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::5c6f:6120:45cd:2880]) by VI1PR05MB4141.eurprd05.prod.outlook.com ([fe80::5c6f:6120:45cd:2880%4]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 12:33:02 +0000 From: Jason Gunthorpe To: Christoph Hellwig CC: =?iso-8859-1?Q?J=E9r=F4me_Glisse?= , Ben Skeggs , Felix Kuehling , Ralph Campbell , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/13] amdgpu: remove -EAGAIN handling for hmm_range_fault Thread-Topic: [PATCH 01/13] amdgpu: remove -EAGAIN handling for hmm_range_fault Thread-Index: AQHVRpr1y4W4rzsfOUifvYDU3qMetqbjGJ+A Date: Tue, 30 Jul 2019 12:33:02 +0000 Message-ID: <20190730123257.GB24038@mellanox.com> References: <20190730055203.28467-1-hch@lst.de> <20190730055203.28467-2-hch@lst.de> In-Reply-To: <20190730055203.28467-2-hch@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: YQXPR0101CA0037.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:14::14) To VI1PR05MB4141.eurprd05.prod.outlook.com (2603:10a6:803:4d::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [156.34.55.100] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c63a4ff3-9a95-4980-1049-08d714ea101d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB5568; x-ms-traffictypediagnostic: VI1PR05MB5568: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(199004)(189003)(446003)(11346002)(53936002)(486006)(5660300002)(2616005)(476003)(256004)(4744005)(6246003)(26005)(6436002)(6512007)(66946007)(6486002)(102836004)(305945005)(66476007)(68736007)(66446008)(64756008)(66556008)(33656002)(8936002)(186003)(1076003)(66066001)(71200400001)(7736002)(81156014)(81166006)(8676002)(229853002)(7416002)(99286004)(2906002)(6916009)(6116002)(54906003)(316002)(36756003)(3846002)(86362001)(478600001)(76176011)(6506007)(386003)(52116002)(14454004)(4326008)(25786009)(71190400001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5568;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zmjHbdaV7n0oJaJsMCF4EFNWeB4AiV0cBG47yTB/uXEz0jC2vezO5Gmfz6/l8WPT4rmGJKyqMgmt0ZoQN8cysSTG4ldcq1gfGWib5l5fXUGScTd1yovF+XAYfQVU3wxD+D3JEBpzJBIXODRU1g86gPdjagbzV43xWQ/J43KxioZlzhuyGyiTVMh+AKUklu0DLv/DPBiTHW22Rif0yz4XpAX3doeicjvUkp9ex5TIIJ0dyRD7fCXTF7uvP72wQhNKg2JsUejBIKiFk4C2CTRt6UsWyckOZxJS81s/ALB8+Zm00MxHgsvvTWHZIgxOLo0YdXjwXeUfAsfPYSe4eeTTtMMsSJ3i6ijZQZSbbKS6wz96bUUizSNR2MIUfPHFpBszzGGHk/WgafoMQI4ayHXWkbH32S0JeX2NsVVVSnvNdY0= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <76FBA5B0F135514A885052AAEE17CDB6@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c63a4ff3-9a95-4980-1049-08d714ea101d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 12:33:02.3076 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jgg@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5568 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 08:51:51AM +0300, Christoph Hellwig wrote: > hmm_range_fault can only return -EAGAIN if called with the block > argument set to false, so remove the special handling for it. >=20 > Signed-off-by: Christoph Hellwig > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 23 +++-------------------- > 1 file changed, 3 insertions(+), 20 deletions(-) Reviewed-by: Jason Gunthorpe Jason