Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4636482ybi; Tue, 30 Jul 2019 05:36:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqycGCF/apVGZxGUir3VHtrdCc6GsMQ8SLEeITpgrPhE88Q47/bpUFLaHevjg6mdycl2Slz5 X-Received: by 2002:a17:90a:2343:: with SMTP id f61mr118484784pje.130.1564490207761; Tue, 30 Jul 2019 05:36:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564490207; cv=none; d=google.com; s=arc-20160816; b=u2RPVSMMpYWL3ci8ShYmantq3wGg1+iKgsicPVMQza6YFD0mj62QYUpfARMnfaYupX wfG4RAThw5skfNXmAJ9Ig8adovKok3Qybe5Tkf2T4ZB4LxSpwiZ9FMwCa2Jnv0CBjEEv 10pFgw7FmyWbIg+XEKye8lFwLfogUWvk57+I2uNG8zjohgagNIBbl0w/PPePLJ/AwWyY 8uG3qZzYto8tkL84dAxXVyP17U1Ybs5e6w9qafFSEUjI5LOI9f6VGLRYGv4ChXrlA1Zx tEog9jlLp0g9jvIqt/FOc9ZzKlD3u3vnWV8BhZaBLd7+m5ucJbZzLpHLNpv+qPfe2+8i CSrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=11fABqqo4gtOOvt/CTC4lgvMCS706eTMhBkk3h5zrVw=; b=hOBpc43ixj/tnLL6lStHuW9DEwLGlYxIg8njTe6UmrqeBKEqYPB2ROoLANF7i5tFCw 65jy2LWgBp9CEFdpmNf+aiDIDGQrHjF7JEj0kBYLBF+DJJtAyc5es9uGTm+qZzqVaDLC obFox6jAqiLsLQtO+k9bKSKe6HNUpimOMqDd4MxDAT5ulE20fP8eA+hKovc+Dd2rNA0z ZnP0NWGglYD+O4TqAgJCMxB+9S8IFmkL/t0IjkyBwJ3Df+vtiuFrCPwETHbmtKt0jMkw ALfFCkhTzz1pggtDIbXfNxYrs6lD/o3LcVhRb2M0+UPtEpLscdEarGgkkg3aFoYog8xt yIXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bg11si25574610pjb.72.2019.07.30.05.36.33; Tue, 30 Jul 2019 05:36:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730018AbfG3Mfj (ORCPT + 99 others); Tue, 30 Jul 2019 08:35:39 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:38845 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbfG3Mfi (ORCPT ); Tue, 30 Jul 2019 08:35:38 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hsRLj-0005tb-FO; Tue, 30 Jul 2019 14:35:27 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hsRLf-0001Vh-M1; Tue, 30 Jul 2019 14:35:23 +0200 Date: Tue, 30 Jul 2019 14:35:23 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: David Lechner Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , William Breathitt Gray , Thierry Reding , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH 2/4] counter: new TI eQEP driver Message-ID: <20190730123523.cjtmr3tpttn6r3pt@pengutronix.de> References: <20190722154538.5314-1-david@lechnology.com> <20190722154538.5314-3-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190722154538.5314-3-david@lechnology.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 10:45:36AM -0500, David Lechner wrote: > This adds a new counter driver for the Texas Instruments Enhanced > Quadrature Encoder Pulse (eQEP) module. > > Only very basic functionality is currently implemented - only enough to > be able to read the position. The actual device has many more features > which can be added to the driver on an as-needed basis. > > Signed-off-by: David Lechner > --- > MAINTAINERS | 6 + > drivers/counter/Kconfig | 12 ++ > drivers/counter/Makefile | 1 + > drivers/counter/ti-eqep.c | 381 ++++++++++++++++++++++++++++++++++++++ > drivers/pwm/Kconfig | 2 +- It's not obvious why the change to drivers/pwm/Kconfig is needed. Can you please motivate that in the change log? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |