Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7fabadbad16242139cd601a0f1e53fd54d309219.camel@surriel.com>
Subject: Re: [PATCH 09/14] sched,fair: refactor enqueue/dequeue_entity
From:   Rik van Riel <riel@surriel.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com,
        dietmar.eggemann@arm.com, mingo@redhat.com,
        morten.rasmussen@arm.com, tglx@linutronix.de,
        mgorman@techsingularity.net, vincent.guittot@linaro.org
Date:   Tue, 30 Jul 2019 08:58:48 -0400
In-Reply-To: <20190730093617.GV31398@hirez.programming.kicks-ass.net>
References: <20190722173348.9241-1-riel@surriel.com>
         <20190722173348.9241-10-riel@surriel.com>
         <20190730093617.GV31398@hirez.programming.kicks-ass.net>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-IEEtM5JqPFAsI0aZR+xY"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-IEEtM5JqPFAsI0aZR+xY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2019-07-30 at 11:36 +0200, Peter Zijlstra wrote:
> On Mon, Jul 22, 2019 at 01:33:43PM -0400, Rik van Riel wrote:
> > @@ -3870,6 +3873,24 @@ static inline void
> > check_schedstat_required(void)
> >   * CPU and an up-to-date min_vruntime on the destination CPU.
> >   */
> > =20
> > +static bool
> > +enqueue_entity_groups(struct cfs_rq *cfs_rq, struct sched_entity
> > *se, int flags)
> > +{
> > +	/*
> > +	 * When enqueuing a sched_entity, we must:
> > +	 *   - Update loads to have both entity and cfs_rq synced with
> > now.
> > +	 *   - Add its load to cfs_rq->runnable_avg
> > +	 *   - For group_entity, update its weight to reflect the new
> > share of
> > +	 *     its group cfs_rq
> > +	 *   - Add its new weight to cfs_rq->load.weight
> > +	 */
> > +	if (!update_load_avg(cfs_rq, se, UPDATE_TG | DO_ATTACH))
> > +		return false;
> > +
> > +	update_cfs_group(se);
> > +	return true;
> > +}
> > =20
>=20
> No functional, but you did make update_cfs_group() conditional. Now
> that
> looks OK, but maybe you can do that part in a separate patch with a
> little justification of its own.

Good idea, I will split that out.

--=20
All Rights Reversed.

--=-IEEtM5JqPFAsI0aZR+xY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl1APwgACgkQznnekoTE
3oPHsQgArvMih+KfhxrafZrsS2tRDAm3iYy+5CQK8wJ3uUAVt6hjG6tBxOmGA9hm
3ZvQMHdj5lw/YDaLRX3SjKV7Zqt2kYe9W0v5LRKWFxXL4NCVuWjnh0P/ZRiAtxxo
0EAjSXYcvLmnQ50acG/yqskdpB/8G+1kSj+nwG8DLB4iPg1+1Vb9C8n3Tji0QhzJ
RMnc7MQXTjS/AecUdCnlOX9nhNs/GBEvK0eh0OJYkCenqaFEFC7o5CQCFwwmmik0
Em+xmh7TNo5KaXPCWwOrKOBZ9TNyhDQDS6rBqz2LStw/UKdU8MxMf0iTaZ9OXT8Y
EwvV8Xaef+acXwTVRzuncLXaWXfY6A==
=mrlW
-----END PGP SIGNATURE-----

--=-IEEtM5JqPFAsI0aZR+xY--