Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Pavel Machek <pavel@denx.de>, "kishon@ti.com" <kishon@ti.com>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>
Subject: RE: phy-rcar-gen3-usb2: wrong parsing of role in role_store?
Thread-Topic: phy-rcar-gen3-usb2: wrong parsing of role in role_store?
Thread-Index: AQHVRrxnhCIU7kKBPE63JOTOwtV/Qqbi73Kw
Date:   Tue, 30 Jul 2019 10:08:33 +0000
Message-ID: <TYAPR01MB4544F1EE39C3A9F36B13D49AD8DC0@TYAPR01MB4544.jpnprd01.prod.outlook.com>
References: <20190730095140.GA29609@amd>
In-Reply-To: <20190730095140.GA29609@amd>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
received-spf: None (protection.outlook.com: renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d67491a7-553a-46c5-c9d8-08d714d5e153
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 10:08:33.5509
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yoshihiro.shimoda.uh@renesas.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB3005
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Pavel,

> From: Pavel Machek, Sent: Tuesday, July 30, 2019 6:52 PM
>=20
> Hi!
>=20
> Code does strcmps, but does not actually check count. So AFAICT
> writing "host-I-don't-want-I-need-peripheral" into the file will
> succeed and turn it into host mode.
>=20
> Also data beyond count in buf are going to be accessed.

Thank you for the report. I think the driver should use sysfs_streq() helpe=
r
instead of strncmp() on the sysfs function. So, I'll submit such a patch la=
ter.

Best regards,
Yoshihiro Shimoda

> Best regards,
> 								Pavel
>=20
> static ssize_t role_store(struct device *dev, struct device_attribute *at=
tr,
>                           const char *buf, size_t count)
> {
>         struct rcar_gen3_chan *ch =3D dev_get_drvdata(dev);
>         bool is_b_device;
>         enum phy_mode cur_mode, new_mode;
>=20
>         if (!ch->is_otg_channel || !rcar_gen3_is_any_rphy_initialized(ch)=
)
>                 return -EIO;
>=20
>         /* FIXME, this is wrong */
>         if (!strncmp(buf, "host", strlen("host")))
>                 new_mode =3D PHY_MODE_USB_HOST;
>         else if (!strncmp(buf, "peripheral", strlen("peripheral")))
>                 new_mode =3D PHY_MODE_USB_DEVICE;
>         else
>                 return -EINVAL;
>=20
>=20
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/b=
log.html