Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4872988ybi; Tue, 30 Jul 2019 09:35:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNYzVzP6HmQIL3Y18h3MEnwEsNr3s4GCrF4+NvBEJr7dXtw/zRIGlgPlmcQpK0ehRBaosE X-Received: by 2002:a17:902:968c:: with SMTP id n12mr121604619plp.59.1564504557074; Tue, 30 Jul 2019 09:35:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564504557; cv=none; d=google.com; s=arc-20160816; b=hDOLwYlJovJ6oigojXOP0A2IFuw8Tf9hat95jJ561W1LxweOLIdouefaPSeRjXIQIb flAHGfAGcKM/3gzj4uquYrXSnN1sbNKx3n1VzfIofIN+0oRmP8+cU9FWnbnI18kgTPpP rj3HAo7vBGsA0/VxxwoUuC1wWgzk3mGgWbPetb5oH/xXiELIdK8v4VX4UuSIBjKFMxeu Z/NTEzJvPUBoerPL5/06/hba+NRsbN1TOTSaYuUBNYNFOC+aSRawe25P+zcwb8Ec87Ag Q2SME2OPfWE6jfIdklVHLeQH2a+eixtOI7UBMxu5o3hMmjLb6R+zpnrNvt5Kih3qoxWJ QIpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8TKN5XccligETEieRmOY0uvOdDLyhkX/2OICv01x9vo=; b=MLaP+zrEGeljrdYjWIJDSGYxpGdnE+3Z0lWe+FHxGHncSf+xhNyTS7v0JFkPLCNH+W iqOCl5tI+3EYC9OQ3JgbeuLLCpIse5oX6WDP9MV+Ry1uLClAg5lExhdMF+1Ai6oEORKr sf4kMTkwsWWaFUr1xMXF9Ct5fUj8van0npkI0WR5ZPehc9jfH66nTUMDmqx8mkySwmye WWSIzD5c/K14S2J4m+6Rj1i68rOagzdsYBHP5G/Hdfg5pOj1x5h60Dd5EZFaczPqEXgJ AXosI/yGAo6O9Oe0g85Xpqeao1r+EjphP93fk3RFOOOqi8dPJp/fxWO/dKkNFclNy0qN wzwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=t+j4Mj8F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si28591561pjt.58.2019.07.30.09.35.42; Tue, 30 Jul 2019 09:35:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=t+j4Mj8F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730974AbfG3OUe (ORCPT + 99 others); Tue, 30 Jul 2019 10:20:34 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46390 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbfG3OUd (ORCPT ); Tue, 30 Jul 2019 10:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8TKN5XccligETEieRmOY0uvOdDLyhkX/2OICv01x9vo=; b=t+j4Mj8FJicNpWJRqkQkRP2OJ Ugo7DZR2UEIA6W2yWIXmoySwvR+koae/Ch3yKZ00Ho0jmZqpVZbqv2BYyhhjO2mWBWi6QJxhNe/nl LNhhqycGI5O1NQ08xJG1O8whrq8WpRed0mg/AAmoNQ0fXHPYHqDBnYWjvzm524d7mNoTU=; Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hsSz5-0007jD-Jf; Tue, 30 Jul 2019 14:20:11 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id A007D2742CB5; Tue, 30 Jul 2019 15:20:10 +0100 (BST) Date: Tue, 30 Jul 2019 15:20:10 +0100 From: Mark Brown To: Thomas Preston Cc: Charles Keepax , Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Marco Felsch , Kuninori Morimoto , Kirill Marinushkin , Cheng-Yi Chiang , linux-kernel@vger.kernel.org, Takashi Iwai , Rob Herring , Liam Girdwood , Paul Cercueil , Vinod Koul , Srinivas Kandagatla , Annaliese McDermond , Jerome Brunet Subject: Re: [alsa-devel] [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine Message-ID: <20190730142010.GG4264@sirena.org.uk> References: <20190730120937.16271-1-thomas.preston@codethink.co.uk> <20190730120937.16271-4-thomas.preston@codethink.co.uk> <20190730124158.GH54126@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8S1fMsFYqgBC+BN/" Content-Disposition: inline In-Reply-To: X-Cookie: Times approximate. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --8S1fMsFYqgBC+BN/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 30, 2019 at 03:04:19PM +0100, Thomas Preston wrote: > On 30/07/2019 13:41, Charles Keepax wrote: > > This could probably be removed using regmap_multi_reg_write. > The problem is that I want to retain the state of the other bits in those > registers. Maybe I should make a copy of the backed up state, set the bits > I want to off-device, then either: > 1. Write the changes with regmap_multi_reg_write > 2. Write all six regs again (if my device doesn't support the multi_reg) Or make this a regmap function, there's nothing device specific about it. --8S1fMsFYqgBC+BN/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1AUhkACgkQJNaLcl1U h9BETgf7BOzHBpbnhWhg2mabB09TWYhaMWdG7DZWPeU+jTPkgFJuIroIGpBf3h/c WIE9G2Zy55KDP7yf1wM1Ad7N18JCMzX+enceVyJ4ZlHhpA3wLhTleyaIdn6JGSHB ++DqO5maWG0iL698Um5bPFI6lvOF9Ewd1KanKCW0hEH93m5C9D5jY4sqItVgEPb1 9vwdUdMo/MqfcwpS3rzXUC98OXCrnC8o0pPDFZT4U5i7X9gNqSSbKIhnBqmCOY+d P6aoGUTv9ZwcZSj1cU1Ty5NKiKAu7asJyWzBvZFc6T9NcAbX3ascLBMWgP5BxYPG LuOQqsFxOiOi3H8N4WlvJk3bvvY1mQ== =0sPL -----END PGP SIGNATURE----- --8S1fMsFYqgBC+BN/--