Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 31 Jul 2019 00:41:53 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        PowerPC <linuxppc-dev@lists.ozlabs.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Kees Cook <keescook@chromium.org>,
        Linux kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch
 fall-through
Message-ID: <20190731004153.6c6198fa@canb.auug.org.au>
In-Reply-To: <878ssfzjdk.fsf@concordia.ellerman.id.au>
References: <20190730143704.060a2606@canb.auug.org.au>
        <878ssfzjdk.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/pIdlFQu0i8FL/lm6/rYKL9L";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/pIdlFQu0i8FL/lm6/rYKL9L
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On Wed, 31 Jul 2019 00:28:55 +1000 Michael Ellerman <mpe@ellerman.id.au> wr=
ote:
>
> Why do we think it's an expected fall through? I can't really convince
> myself from the surrounding code that it's definitely intentional.

Its been that way since this code was introduced by commit

  0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support")

in 2005 ...

--=20
Cheers,
Stephen Rothwell

--Sig_/pIdlFQu0i8FL/lm6/rYKL9L
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1AVzEACgkQAVBC80lX
0Gw/rwf+P6QPr+aB8iXvRzPQ1R6e2idCJJup+E7e51Z/Gl59GezLyodDWg3UcALE
lmzirNhyw1ZwnlhfpzcJ5pzHazfn7z/37UuqjUVenq9VWaYiZLRY6XA5ufe3aj6X
Q7xVeJplLON1xKRp+34fPYA3+mYQqNEWhgdsrHzxrSje+aXE3Wac0ArVLPL0ct59
/w/OOidJMAsh3InX2KUK3i83tGUPMyBby56/owxqpJLXFpuFlOpL+vb0ymEawkkL
/gqftyc45jwNC75tOE/17Km8qNqiFSKjQArDgDA3iyjLF1edvr/iNQZBjcRe9WFc
6+5WYM6uIpZVv+og6vpdSzUW3/zvug==
=1jvs
-----END PGP SIGNATURE-----

--Sig_/pIdlFQu0i8FL/lm6/rYKL9L--