Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4894192ybi; Tue, 30 Jul 2019 09:59:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxpp59uRMkgS4yL4Z3cRO4HvK6D1FOt1wlUPu8l8ErPZoYKYVXdXN2vZy1WBfhKpjxODVF X-Received: by 2002:a65:4786:: with SMTP id e6mr107294686pgs.448.1564505986528; Tue, 30 Jul 2019 09:59:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564505986; cv=none; d=google.com; s=arc-20160816; b=SyIJ4fxRdg/vHA9TLVol+DQxYzR/0muRc6Ju0mBIeOv6m2e7k5xJPBG8PvzQ52ReWy lostIJj8EqJheDUYh82BfyMBBXJTtq6NIdxja+m+t6+uvk9hlhGcua8NfvnLg33xDKtV ZyllCD9b22IoZRXpygK08zTbuMfqn/sEvZmHmg+resj5DB4wgTRixBgCn37GUpqJrkMa wR+6f3gWjIouOgpt45KpX4Ga+3QqB3HFe+f4FyOhbDR9NDCht2BJbNm46X3uPV7FG9qv MMeaQ7ZHO192tPnjYLF85nAKF711X4NaQaRHuzNEyH0IWlwqmI4rdAA8WyddmBdkcQKj d5jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=VftaCj3cQ2jrmMxrQ0Mbq1ohzPe1+pRbs5qp2YXmAMc=; b=ng7fm5dOXl5La2sdUg2ES5BxucT8ezdulSv6ziR4IFvBIuiLSLdewN1LDpnuDQBvFs JD+9XbBD6/e0MRV52AFHsXuaCbfYP6ghjotObPISndLNWLA4SvtlZ5+FE/BPru5QAXbS pyVScAGcq+NRUqvzNcshb08AgdJD1zweWfvIqH6cbpAv03SRBXmdRJrtE1o8dz13tmoP kbizcqK3gwFBc5BFIZ2pvfeBSuT+YItF3fxp7jrAH94BiTQGBroW5ZedfMvvTqTL+G/W HWNzjU4Zids0tU91HjW0EQY+e5goUdtUCgjG3/vNFIl5wuKYCcsN5yKS0cuygw8EgPe1 CckA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y186si29413068pgd.440.2019.07.30.09.59.31; Tue, 30 Jul 2019 09:59:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729111AbfG3Qzf (ORCPT + 99 others); Tue, 30 Jul 2019 12:55:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51880 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727576AbfG3Qzf (ORCPT ); Tue, 30 Jul 2019 12:55:35 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 934681264EC66; Tue, 30 Jul 2019 09:55:34 -0700 (PDT) Date: Tue, 30 Jul 2019 09:55:34 -0700 (PDT) Message-Id: <20190730.095534.1629843557426676625.davem@davemloft.net> To: h.feurstein@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH] net: phy: fixed_phy: print gpio error only if gpio node is present From: David Miller In-Reply-To: <20190730094623.31640-1-h.feurstein@gmail.com> References: <20190730094623.31640-1-h.feurstein@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jul 2019 09:55:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hubert Feurstein Date: Tue, 30 Jul 2019 11:46:23 +0200 > It is perfectly ok to not have an gpio attached to the fixed-link node. So > the driver should not throw an error message when the gpio is missing. > > Signed-off-by: Hubert Feurstein Applied and queued up for -stable, thanks.