Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4906175ybi; Tue, 30 Jul 2019 10:10:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+OG7TVu3Y0S4qLYggCnmykCiypEXKRwIV8HNeNTEiglwywXpGsl0c7WKNSrfeR9gnOawq X-Received: by 2002:a17:90a:fa12:: with SMTP id cm18mr117807153pjb.137.1564506659036; Tue, 30 Jul 2019 10:10:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564506659; cv=none; d=google.com; s=arc-20160816; b=OeRuJ/h1j9ky6dSByFxnMebJxAPcY8e0VIPtZZgN9/2gSOi6gU4ey4h2t+MMwtCF+J ruUUyP4HPtPlxh3/MWriw7yBlO6/VO2GGP007HdTl7JVRrwROZGwyTyxIOAMKUuwOo1y SKNpkuLQHCjRNRtzF9YI6fvYtirItqXX6nWctGnISsyL4KGEeT053AzAo2u+g3cPDxfH 55a30PY0vLA+5QOGhDGowS/J6M3pWjId7+D5i9Zb7NXkU6eW3n1QlOoZm0GIdptfNS5m 3RIdCWvMJ0qbxSfzrYznlJNzreasWARTS6PjzyLaWBcQoRFJhCMIRDTaz+QH7v6tzm0g CkRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QHsEukcprFLg52vl477sHWg95fi+cAPia7f4linik4U=; b=uZzR4vB61ujRO2iTqSwkH1l5wX8tNPDf4jJB/nb6lrOf766jIZaijJwsp1VuNAnOXA KE2TXkXOLjz7sRiJBNgZpjt4b/zhAKg8Zjg9YdC8EIfORHjtIH8RwpThwDKjhsJeLlYA vaEp4HE6kVapksAA1/5hMsIF4IoCv9hZlLWV6KHMcxUdjDbgUvfjAtyNWOs4E/lJw8oM OkycgOcKdhh3Gd0Uc9N86fZt44hRpJ6xGuZoj3sJEG7yv1ZtcZJF/Ydz7QsU4SFOV4Fh PjXixlfN5thYbuHQwJMEFUwWGI1dZyODQRAyDyz+Eba11LObUF9bc0b6PY3Fl0i6735u 2PfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hNRILnIG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f37si22145645pgm.145.2019.07.30.10.10.44; Tue, 30 Jul 2019 10:10:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hNRILnIG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730879AbfG3LqB (ORCPT + 99 others); Tue, 30 Jul 2019 07:46:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:39920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728590AbfG3LqA (ORCPT ); Tue, 30 Jul 2019 07:46:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D767D206E0; Tue, 30 Jul 2019 11:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564487159; bh=MdCmTq2/62GOla3xYdR1q+U30DvmMzx9ilbakjTfbuY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hNRILnIGpwN0IQ17UgUT9sNy5oW3a2JqVMfOgkS1x5zDIp+bnrnOA5gUA3vFMnckT ImalFhGvGWcRgYOH4oWtJGoEErv0Hg16NWumKADitrYbYxaF5WUPl3I9wt65hcy2D5 UpEcc6XDJDwSe5h8nvuSvpKdK1R8vJAO2KCAu+Nk= Date: Tue, 30 Jul 2019 13:45:56 +0200 From: Greg Kroah-Hartman To: Brian Norris Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, Salvatore Bellizzi , andy.shevchenko@gmail.com, Dmitry Torokhov , egranata@chromium.org, egranata@google.com, Enric Balletbo i Serra , Gwendal Grignou , linux-acpi@vger.kernel.org, Benson Leung , stable@vger.kernel.org Subject: Re: [PATCH] driver core: platform: return -ENXIO for missing GpioInt Message-ID: <20190730114556.GA10673@kroah.com> References: <20190729204954.25510-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729204954.25510-1-briannorris@chromium.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 01:49:54PM -0700, Brian Norris wrote: > Commit daaef255dc96 ("driver: platform: Support parsing GpioInt 0 in > platform_get_irq()") broke the Embedded Controller driver on most LPC > Chromebooks (i.e., most x86 Chromebooks), because cros_ec_lpc expects > platform_get_irq() to return -ENXIO for non-existent IRQs. > Unfortunately, acpi_dev_gpio_irq_get() doesn't follow this convention > and returns -ENOENT instead. So we get this error from cros_ec_lpc: > > couldn't retrieve IRQ number (-2) > > I see a variety of drivers that treat -ENXIO specially, so rather than > fix all of them, let's fix up the API to restore its previous behavior. > > I reported this on v2 of this patch: > > https://lore.kernel.org/lkml/20190220180538.GA42642@google.com/ > > but apparently the patch had already been merged before v3 got sent out: > > https://lore.kernel.org/lkml/20190221193429.161300-1-egranata@chromium.org/ > > and the result is that the bug landed and remains unfixed. > > I differ from the v3 patch by: > * allowing for ret==0, even though acpi_dev_gpio_irq_get() specifically > documents (and enforces) that 0 is not a valid return value (noted on > the v3 review) > * adding a small comment > > Reported-by: Brian Norris > Reported-by: Salvatore Bellizzi > Cc: Enrico Granata > Cc: > Fixes: daaef255dc96 ("driver: platform: Support parsing GpioInt 0 in platform_get_irq()") > Signed-off-by: Brian Norris > Reviewed-by: Andy Shevchenko > Acked-by: Enrico Granata > --- > Side note: it might have helped alleviate some of this pain if there > were email notifications to the mailing list when a patch gets applied. > I didn't realize (and I'm not sure if Enrico did) that v2 was already > merged by the time I noted its mistakes. If I had known, I would have > suggested a follow-up patch, not a v3. > > I know some maintainers' "tip bots" do this, but not all apparently. We can't drown out mailing list traffic with a ton of "this patch was applied" emails. We send them directly to the people involved in it. Note, you can always set up your own "watch" for stuff like this by pulling linux-next every day and sending yourself any new patches that get applied for any specific files/directories you are concerned about. thanks, greg k-h