Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     =?iso-8859-1?Q?J=E9r=F4me_Glisse?= <jglisse@redhat.com>,
        Ben Skeggs <bskeggs@redhat.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/13] mm: remove the unused vma argument to
 hmm_range_dma_unmap
Thread-Topic: [PATCH 05/13] mm: remove the unused vma argument to
 hmm_range_dma_unmap
Thread-Index: AQHVRpr6u0kOQaNySU6qr8LRJOBbn6bjHBGA
Date:   Tue, 30 Jul 2019 12:45:22 +0000
Message-ID: <20190730124517.GE24038@mellanox.com>
References: <20190730055203.28467-1-hch@lst.de>
 <20190730055203.28467-6-hch@lst.de>
In-Reply-To: <20190730055203.28467-6-hch@lst.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [156.34.55.100]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 55501426-92a3-498b-08b1-08d714ebc934
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB6079;
x-ms-traffictypediagnostic: VI1PR05MB6079:
x-microsoft-antispam-prvs: <VI1PR05MB60795EB36AC26291165643D4CFDC0@VI1PR05MB6079.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 0114FF88F6
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(199004)(189003)(36756003)(3846002)(6116002)(305945005)(7736002)(76176011)(2906002)(4326008)(102836004)(6436002)(186003)(6916009)(478600001)(7416002)(316002)(71190400001)(229853002)(71200400001)(26005)(14454004)(446003)(11346002)(52116002)(25786009)(54906003)(6506007)(6486002)(256004)(6512007)(33656002)(53936002)(6246003)(66946007)(66556008)(64756008)(81166006)(81156014)(8936002)(1076003)(8676002)(476003)(386003)(486006)(2616005)(5660300002)(4744005)(66476007)(66446008)(99286004)(68736007)(66066001)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB6079;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: wApwXHSaZLo6Bej8GHUpHxofhQJqUdBaqEIIrGPYuB4TX/9bwFevZGwg5WoGakIPJh2DRaQCY1+1pqemO6g8GWj/tAV9n5OGoC65RJjgsVDRpPnMZH9FzvjI575dntSPJnyBeeAqfrsR6xbzD4DI+JYRT0jjZO511rYBO1tkL4YspouD3qDdhfzELBOdpYwc6vfJzQkP06xwQATk/C/D0MkCzu6cG9CP/Livzu7o6kHh85TvZoY/t55fuMCj3g5fWbKnLToGhgTcO4LfEJlJYRp5H8Grim9/eSB53A+OzJIHXP0C8BRmOGvAHJNBmvdEyChJgb2EvTzCmtrygnOPu2OJfclfnxZBR5JSRgcxEdH8V+wjL87n9hhnV4n/BM5kzUyUPwdZmIZLvA5idTQgmnk/2w+FJSehxJc1TEG0IK8=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <5AEF0910AD27734B9CD8F3EB448FDE35@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55501426-92a3-498b-08b1-08d714ebc934
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 12:45:22.3504
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jgg@mellanox.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6079
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 30, 2019 at 08:51:55AM +0300, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>  include/linux/hmm.h | 1 -
>  mm/hmm.c            | 2 --
>  2 files changed, 3 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>

Unclear what this was intended for, but I think if we need to carry
information from the dma_map to unmap it should be done in some opaque
way.

The driver should not have to care about VMAs, beyond perhaps using
VMAs to guide what VA ranges to mirror.

Jason