Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190730154027.101525-1-drinkcat@chromium.org> <20190730154204.GC15386@arrakis.emea.arm.com>
In-Reply-To: <20190730154204.GC15386@arrakis.emea.arm.com>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Tue, 30 Jul 2019 18:23:44 +0200
Message-ID: <CACT4Y+ZRoSeBw=NUxvnLR+GAHweDgyV+3YkzeZiW3f85STqMpQ@mail.gmail.com>
Subject: Re: [PATCH] kmemleak: Increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default
 to 16K
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Nicolas Boichat <drinkcat@chromium.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Kees Cook <keescook@chromium.org>,
        Petr Mladek <pmladek@suse.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        Uladzislau Rezki <urezki@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 30, 2019 at 5:42 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Tue, Jul 30, 2019 at 11:40:27PM +0800, Nicolas Boichat wrote:
> > The current default value (400) is too low on many systems (e.g.
> > some ARM64 platform takes up 1000+ entries).
> >
> > syzbot uses 16000 as default value, and has proved to be enough
> > on beefy configurations, so let's pick that value.
> >
> > This consumes more RAM on boot (each entry is 160 bytes, so
> > in total ~2.5MB of RAM), but the memory would later be freed
> > (early_log is __initdata).
> >
> > Suggested-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Acked-by: Dmitry Vyukov <dvyukov@google.com>