Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 30 Jul 2019 13:07:38 -0400
From:   Sean Paul <sean@poorly.run>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     a.hajda@samsung.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, airlied@linux.ie, daniel@ffwll.ch,
        seanpaul@chromium.org, heiko@sntech.de,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static
Message-ID: <20190730170738.GR104440@art_vandelay>
References: <20190730150057.57388-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190730150057.57388-1-yuehaibing@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 30, 2019 at 11:00:57PM +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
>  symbol 'analogix_dp_atomic_check' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks for your patch, applied to drm-misc-next

Sean

> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index c82c7d5..f2f7f69 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
>  }
>  
>  
> -int analogix_dp_atomic_check(struct drm_connector *connector,
> -			     struct drm_atomic_state *state)
> +static int analogix_dp_atomic_check(struct drm_connector *connector,
> +				    struct drm_atomic_state *state)
>  {
>  	struct analogix_dp_device *dp = to_dp(connector);
>  	struct drm_connector_state *conn_state;
> -- 
> 2.7.4
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS