Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp4961335ybi; Tue, 30 Jul 2019 11:12:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbBrYimBGvFWV7DOpHzJtBUrHqCBnIPvxS/l2ipw2QMA6tYPdXVHTddZVQXCRYWPAy8t3r X-Received: by 2002:a17:90a:710c:: with SMTP id h12mr115913359pjk.36.1564510324998; Tue, 30 Jul 2019 11:12:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564510324; cv=none; d=google.com; s=arc-20160816; b=wDFh9U6kv5AxP5trkGnGvlTSLCoeVX3SbOFMJ0IsCRdlGck9f30WxeZtQm26X5VOhX 0FwB+OcVaounuhXFes2cEkQwFCebSWxIqKL1Bg54pM+wxC5akieu6G8EaVCR7cPFktMJ 7FaODZNUUVFC/O1UehtVw8h7Q+kw9Ud0ZqoWFon5BVSohOiqSF0eoMltMjaLxC3r/phO fnqrVVINRds6u/Vs+MSNEb37GxxZl2W1KxoOspkrlZREIi5wlDoYGBrCJ0krVz5sPkox GPDoc3jJZ3rnuAxMcNeOv0YovoJL20z9TIiDX1F/WqiaevwjpVMOSNq8U7Mk/oooBt4S gHpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Tb/59Mw4YFVHbVjuj+J+klv9gol8MtqBAPT9c0q/qWw=; b=SO93BTGEB0OOQiYIQlYQHtO8YWG+3WHbRlm2Ff/9CkwOTzmgkrC0uwShWgYexkx/Bp Ohfd20F/rI2GpEILyQXI5Bdh4KaQOXyUVT//Cg+1hmFHrj/schjxl0aXiHuN3V7iMve8 em5Oo19BMTW+LYTbqEkKJH913m5cmPTCDawvOj72+TfPuJln75pgV3Bm1eM7+EfUWeHg tAbpwpicYZBTmGXvNnuU0GobxdrgXgGqiUgkiG7BQG9K525bsa1YSC4lSLx1V+9m2Xqe cXfpMkO2BOQ75H7vULUTMtEGjfprX55fELq/7BT5U7GQ+edmGdQ22YkLYsLjvlOJc5Y2 cgUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x130si34679414pgx.526.2019.07.30.11.11.50; Tue, 30 Jul 2019 11:12:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728839AbfG3R2w (ORCPT + 99 others); Tue, 30 Jul 2019 13:28:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52494 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbfG3R2w (ORCPT ); Tue, 30 Jul 2019 13:28:52 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B7B571239C4CE; Tue, 30 Jul 2019 10:28:51 -0700 (PDT) Date: Tue, 30 Jul 2019 10:28:51 -0700 (PDT) Message-Id: <20190730.102851.1996008524459618236.davem@davemloft.net> To: yuehaibing@huawei.com Cc: claudiu.manoil@nxp.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] enetc: Fix build error without PHYLIB From: David Miller In-Reply-To: <20190730142959.50892-1-yuehaibing@huawei.com> References: <20190730142959.50892-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jul 2019 10:28:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Tue, 30 Jul 2019 22:29:59 +0800 > If PHYLIB is not set, build enetc will fails: > > drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_open': > enetc.c: undefined reference to `phy_disconnect' > enetc.c: undefined reference to `phy_start' > drivers/net/ethernet/freescale/enetc/enetc.o: In function `enetc_close': > enetc.c: undefined reference to `phy_stop' > enetc.c: undefined reference to `phy_disconnect' > drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to `phy_ethtool_get_link_ksettings' > drivers/net/ethernet/freescale/enetc/enetc_ethtool.o: undefined reference to `phy_ethtool_set_link_ksettings' > drivers/net/ethernet/freescale/enetc/enetc_mdio.o: In function `enetc_mdio_probe': > enetc_mdio.c: undefined reference to `mdiobus_alloc_size' > enetc_mdio.c: undefined reference to `mdiobus_free' > > Reported-by: Hulk Robot > Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drivers") > Signed-off-by: YueHaibing Applied.