Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5017437ybi; Tue, 30 Jul 2019 12:14:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSo9mWsPznQLMmczkfz7iIFKazEFrVqyN6Max+eadvyfTqzT5HQ1doWhDphDc5jWWDmHfH X-Received: by 2002:a63:6f81:: with SMTP id k123mr112428200pgc.12.1564514074909; Tue, 30 Jul 2019 12:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564514074; cv=none; d=google.com; s=arc-20160816; b=NIuP33JNjLH1bhQ6tOcnI+DSiMBPXib5RDAvIj+x2Fv6Jpy+t1JZ+h0sv8ZT9WXg9Q T9lZr1TGc7sbj+gh3dIgA3rTldIgNZYAz1alcu7dfwLu6pkPL6B/Lw2d8DQ+hYLK26FO fGaKa9R8cKDU4Ok4fw4iWPbwkQBxsKbTU8niayiDwXOqcKM6K7sYvEJQhWTbv7dDFa4c UBFaR8OBJObb5d+1RTDrypTqOu+skcEhmrBISPiUH0jBAV2qfz0rLTHAb7eEaik05Qdq rdqi+9cw8cml9tGfpz3H3WlceJYbtVZyjAfDddfvnzGIwppkV0RbKX13g53s7s+DHqVy 01Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=djb+K5YV06tE6CuanEg0CCbjMrpDNzEbnLAfye7ZkSY=; b=UbClQuH4phWqLf66gj8T2/em4X0r91sZsXfbTCRw8SETcFsHruD9z9yeWTMtla8K7W qAYyI3N2/9eiENJVV9kDzY3N5sGVcgqof6dVg4WCsnlFJN+y8IaZ3BLVoffLYXGZ/Vzh gwXlfXDjSndfQs2idTq5aHHXVzDQLxKQ4/3VjxXaP/u7PzeiLXwMX03NzgpsefKreFOG GC39d86GWXI6tMwlWRkDG/Kx6J13R07Uty1EUFe9+wenwaNKfDw53BxfjX5boZAJUYeY fQea07q3kd/uARc6Ruq7wfOAVuW91trVbX5W1GhMELUsbfL8LM4DEXeDEuihaJNxaBgT KdTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NEHgj6CU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si30524158pgy.255.2019.07.30.12.14.19; Tue, 30 Jul 2019 12:14:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=NEHgj6CU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728504AbfG3TNg (ORCPT + 99 others); Tue, 30 Jul 2019 15:13:36 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:37698 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388320AbfG3TN1 (ORCPT ); Tue, 30 Jul 2019 15:13:27 -0400 Received: by mail-pl1-f194.google.com with SMTP id b3so29294621plr.4 for ; Tue, 30 Jul 2019 12:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=djb+K5YV06tE6CuanEg0CCbjMrpDNzEbnLAfye7ZkSY=; b=NEHgj6CUyhuGNXZT844G24GmkoVlxjwnp/ZZK+KeYPZYfnl+y2UvSztPruWijQ4cSI kBY38ehlnCl9JH9OOX/JsC03zQgxQlLzWzBZnYs6E5MkdIvE+bVThcfwBcwDd1fydiyS XhhW1KJvnX2Qrszc09rMS6Fb8iqbbIIl1pYec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=djb+K5YV06tE6CuanEg0CCbjMrpDNzEbnLAfye7ZkSY=; b=l1npUPsvYeCBncVcWS3uV5I7OBLKyp2VMwTOoar3nw4pD1k5fNNiD9Sp9ExDnDQfxb apXkpleqmfccJdXTjMSC01EGm5KUkh9QHGsZRHSJZUOM8PbXtiJi6GO1iRSwwSQPvw4r oScLc6gigNAAZpjHkhepdy5Jn95OGmIbbzExre/f6YlEtU09D8OrHydT2ncD4JJ2gLH6 EPZEGP1MsN/MjKS8mRLg5jFlnvANOgvldWeTsGgn1vRzVII6LdqJ5moHspfeyGQwDy7f Y6+jJsgAmgCHb7n9MtTrTnaog4VUT7GKArFMXooTJxef3yEVADReGTWsRXM4aKfRSCbW S+ig== X-Gm-Message-State: APjAAAVR8bNRzxbdv8Cuwd1unydt44J2DUS06UN130jOR41YtppiVHO7 7zlcMbDNKUWB6rFJhBzHgV0k9w== X-Received: by 2002:a17:902:42a5:: with SMTP id h34mr120262792pld.16.1564514006452; Tue, 30 Jul 2019 12:13:26 -0700 (PDT) Received: from skynet.sea.corp.google.com ([2620:0:1008:1100:c4b5:ec23:d87b:d6d3]) by smtp.gmail.com with ESMTPSA id n89sm84649540pjc.0.2019.07.30.12.13.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 12:13:26 -0700 (PDT) From: Thomas Garnier To: kernel-hardening@lists.openwall.com Cc: kristen@linux.intel.com, keescook@chromium.org, Thomas Garnier , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Peter Zijlstra , Nadav Amit , linux-kernel@vger.kernel.org Subject: [PATCH v9 11/11] x86/alternatives: Adapt assembly for PIE support Date: Tue, 30 Jul 2019 12:12:55 -0700 Message-Id: <20190730191303.206365-12-thgarnie@chromium.org> X-Mailer: git-send-email 2.22.0.770.g0f2c4a37fd-goog In-Reply-To: <20190730191303.206365-1-thgarnie@chromium.org> References: <20190730191303.206365-1-thgarnie@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change the assembly options to work with pointers instead of integers. Position Independent Executable (PIE) support will allow to extend the KASLR randomization range below 0xffffffff80000000. Signed-off-by: Thomas Garnier --- arch/x86/include/asm/alternative.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/alternative.h b/arch/x86/include/asm/alternative.h index 094fbc9c0b1c..28a838106e5f 100644 --- a/arch/x86/include/asm/alternative.h +++ b/arch/x86/include/asm/alternative.h @@ -243,7 +243,7 @@ static inline int alternatives_text_reserved(void *start, void *end) /* Like alternative_io, but for replacing a direct call with another one. */ #define alternative_call(oldfunc, newfunc, feature, output, input...) \ asm volatile (ALTERNATIVE("call %P[old]", "call %P[new]", feature) \ - : output : [old] "i" (oldfunc), [new] "i" (newfunc), ## input) + : output : [old] "X" (oldfunc), [new] "X" (newfunc), ## input) /* * Like alternative_call, but there are two features and respective functions. @@ -256,8 +256,8 @@ static inline int alternatives_text_reserved(void *start, void *end) asm volatile (ALTERNATIVE_2("call %P[old]", "call %P[new1]", feature1,\ "call %P[new2]", feature2) \ : output, ASM_CALL_CONSTRAINT \ - : [old] "i" (oldfunc), [new1] "i" (newfunc1), \ - [new2] "i" (newfunc2), ## input) + : [old] "X" (oldfunc), [new1] "X" (newfunc1), \ + [new2] "X" (newfunc2), ## input) /* * use this macro(s) if you need more than one output parameter -- 2.22.0.770.g0f2c4a37fd-goog