Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, Joe Jin <joe.jin@oracle.com>,
        Aruna Ramakrishna <aruna.ramakrishna@oracle.com>,
        Srinivas Eeda <srinivas.eeda@oracle.com>
References: <1564444954-28685-1-git-send-email-divya.indi@oracle.com>
 <1564444954-28685-8-git-send-email-divya.indi@oracle.com>
 <20190729205138.689864d2@gandalf.local.home>
From:   Divya Indi <divya.indi@oracle.com>
Message-ID: <8e50d405-a4fb-fadf-509e-157b031d7542@oracle.com>
Date:   Tue, 30 Jul 2019 15:29:41 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190729205138.689864d2@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steven,

On 7/29/19 5:51 PM, Steven Rostedt wrote:
> On Mon, 29 Jul 2019 17:02:34 -0700
> Divya Indi <divya.indi@oracle.com> wrote:
>
>> Use "trace_array_set_clr_event" to enable/disable events to a trace
>> array from other kernel modules/components.
>> Hence, we no longer need to have ftrace_set_clr_event as an exported API.
> Hmm, this simply reverts patch 1. Why have patch 1 and this patch in
> the first place?

Right! First patch fixes issues in a previous commit and then this patch 
reverts the part of previous commit that required the fix.

We can eliminate the first patch if it seems counter intuitive.


Thanks,

Divya

>
> -- Steve
>
>> Signed-off-by: Divya Indi <divya.indi@oracle.com>
>> Reviewed-By: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>