Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190731024533.22264-1-huangfq.daxian@gmail.com> <520bd0f7367e77ffd2e0150187f6ffb64b0e8b71.camel@perches.com>
In-Reply-To: <520bd0f7367e77ffd2e0150187f6ffb64b0e8b71.camel@perches.com>
From:   Fuqian Huang <huangfq.daxian@gmail.com>
Date:   Wed, 31 Jul 2019 14:26:07 +0800
Message-ID: <CABXRUiSYbyb8+bsvCb_+n1kLEA_ZSFxR5D7c+qatrW9KPGmeqw@mail.gmail.com>
Subject: Re: [PATCH] drm: use trace_printk rather than printk in drm_dbg.
To:     Joe Perches <joe@perches.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Joe Perches <joe@perches.com> =E6=96=BC 2019=E5=B9=B47=E6=9C=8831=E6=97=A5=
=E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=882:06=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Wed, 2019-07-31 at 10:45 +0800, Fuqian Huang wrote:
> > In drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c,
> > amdgpu_ih_process calls DRM_DEBUG which calls drm_dbg and
> > finally calls printk.
> > As amdgpu_ih_process is called from an interrupt handler,
> > and interrupt handler should be short as possible.
> >
> > As printk may lead to bogging down the system or can even
> > create a live lock. printk should not be used in IRQ context.
> > Instead, trace_printk is recommended.
> > Link: https://lwn.net/Articles/365835
> []
> > diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
> []
> > @@ -236,7 +236,7 @@ void drm_dbg(unsigned int category, const char *for=
mat, ...)
> >       vaf.fmt =3D format;
> >       vaf.va =3D &args;
> >
> > -     printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV",
> > +     trace_printk(KERN_DEBUG "[" DRM_NAME ":%ps] %pV",
> >              __builtin_return_address(0), &vaf);
> >
> >       va_end(args);
>
> This makes all 4000+ drm_dbg/DRM_DEBUG uses emit
> a trace_printk.
>
> I suggest instead you make only the interrupt uses
> use a different function and not drm_dbg.
>
> Or maybe add an in_interrupt() check like
>
>         if (in_interrupt())
>                 printk(KERN_DEBUG etc...)
>         else
>                 trace_printk(etc...)

I will send a v2 patch to fix this.