Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5674681ybi; Wed, 31 Jul 2019 01:28:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxKrr1gcI9fs3lm/uzCSTneOXdk6z4F4J061jYjuqrYT0leERzqdN9Z/TdTC83AZ5dmRGWx X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr116309499plo.157.1564561700716; Wed, 31 Jul 2019 01:28:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564561700; cv=none; d=google.com; s=arc-20160816; b=SBFit4SOvUELHzqXndG5KsPazhyKzftCI5YCqF36Pr37CQCAwqeN0CQqXK0iXFsijK +mAIr8/AOdcIsghDAbJr1nS5ss++QOtXT/Yjk+v8rN0kkQk22w3LvThY0QTYPZFsMb10 /qqfbQODmOMh/0RUAuPaScg/CjV4WK+G0qYKmd4bHojtSY9J7LdBuyxB+h+AulSqxTt0 fbQHcvM7gFqMEuZQzJkMhXl5Z1bR5BNhrPZXRRuKdasedzGCrnnp7i8R2xkrJfBQJQcL 491yHTp4Gemgm2QTQAFkr61DREgN8jk5MoPxTddsupUQY/y/FFKWztKkOwFShtlNWapw oM/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=4Yv8d80xlN02BJ7pUjjFwysGxviAEDJueZ5dvsRAp+A=; b=EWgbn0MGaE4r+/fNQFCLSovzY0I1aReJ+Q5eeCmgeU6Ji0ureCMPziSrNvKgNz/KOW 7Y0WfFsXDmB0wuIq2NhVHP8sBKcTIhAz/J0rFcvdGz96/7FB2Dij/lKSWaT8lrc7NUO6 e4Xmyx2H4SEHaSc2XCopCJORYl+xrH52pLtnpkdIchBLD4gLsK04YysQZBFnSUClDo9C qZlK8Vlq1TsrhSEekwVWd4oppcIjmBuNemDFYePSI/Ii4/HKMsskf8rDRHnqDlLUeUi6 vOwWOdWLgFY+zN7/aSoEXNO6TTC881Dd3tXhEPvisanqEA5pItBftkkzstjBkF3alfpA 2Y7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si31606623pgf.335.2019.07.31.01.28.05; Wed, 31 Jul 2019 01:28:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbfGaHPP (ORCPT + 99 others); Wed, 31 Jul 2019 03:15:15 -0400 Received: from olimex.com ([184.105.72.32]:46116 "EHLO olimex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfGaHPP (ORCPT ); Wed, 31 Jul 2019 03:15:15 -0400 Received: from localhost.localdomain ([94.155.250.134]) by olimex.com with ESMTPSA (ECDHE-RSA-AES128-GCM-SHA256:TLSv1.2:Kx=ECDH:Au=RSA:Enc=AESGCM(128):Mac=AEAD) (SMTP-AUTH username stefan@olimex.com, mechanism PLAIN) for ; Wed, 31 Jul 2019 00:15:12 -0700 From: Stefan Mavrodiev To: Srinivas Kandagatla , Maxime Ripard , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Allwinner sunXi SoC support), linux-kernel@vger.kernel.org (open list) Cc: linux-sunxi@googlegroups.com, Stefan Mavrodiev Subject: [PATCH 1/1] nvmem: sunxi_sid: fix A64 SID controller support Date: Wed, 31 Jul 2019 10:14:47 +0300 Message-Id: <20190731071447.9019-2-stefan@olimex.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190731071447.9019-1-stefan@olimex.com> References: <20190731071447.9019-1-stefan@olimex.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Like in H3, A64 SID controller doesn't return correct data when using direct access. It appears that on A64, SID needs 8 bytes of word_size. Workaround is to enable read by registers. Signed-off-by: Stefan Mavrodiev --- drivers/nvmem/sunxi_sid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c index a079a80ddf2c..e26ef1bbf198 100644 --- a/drivers/nvmem/sunxi_sid.c +++ b/drivers/nvmem/sunxi_sid.c @@ -186,6 +186,7 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = { static const struct sunxi_sid_cfg sun50i_a64_cfg = { .value_offset = 0x200, .size = 0x100, + .need_register_readout = true, }; static const struct sunxi_sid_cfg sun50i_h6_cfg = { -- 2.17.1