Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5692274ybi; Wed, 31 Jul 2019 01:47:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxmihJ7k7i9M8pKBkcrlM9NtEP6YYRM87CU+o4tSNc5uz0o6CoRk+qXB0OL3ADVc8m/FH+J X-Received: by 2002:a63:6904:: with SMTP id e4mr51903553pgc.321.1564562849875; Wed, 31 Jul 2019 01:47:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564562849; cv=none; d=google.com; s=arc-20160816; b=wx0+nBLkHJ8zt2ZftE0RJW0frFDuUTRXVRvcfwIWBEvwbhnGeXVOi2NZUxSkVVzQJj m9NOhyCRSAmyogHiQtcpB18xVg9TxbO14ctXGgnpFKXauMU0KVL/apLV6t56GkIhWtY9 XgK3iLFdrK3FbVHQofbwaMYjUHZoLjjtBiNlwJ9HjJOFPDAQOqEi0a6k3VCIjRSoMfQF A7PMQrGeo7mZtyHI9PmiRSD1eFkPB20UYnbVABE7HrYTeosLyrqQg6Tqvec+Ql8GGuoI XFTUK3A/ssBvTtaGoyDWT2ZIFkxsM5lQH6bwgI1Dcz13AAYmiYs6qVYaJVzsyNN9WAbk uiiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=RJYmquIS1e528+G/ixh1cYrRMeCXLDQDyBuin0HsHOE=; b=XmPLXlsosO8t/MKaQtS61QGsBw2jVHxZswjc785bCdsG4s6zwsjRmnlYpFJH+srDBF W/BaF88kAoffJC9gxyxMVyUkbZ5f3DaPFhcFVpN3KNXtx9RhbUOMHD8upgV37QD/ZD8S HDZBst/ayfMNGPOVDvk82iN5wQ1yjCZdmys7uC/M9iodv3lxklMblbsEaVAwZyYyu02m 1XbWVF526z9MHLxHRDYgQgNF71C7TLYCNaubFTvjZ3nfSrP/ejH7ykBpzPiFME9Y3k5f 3JDBT0W8v+y+iUF8s1NDIj1pTYAFPGLKD59NW92xXb5IeqkVhhhrLlfBvM+GGTzLnEt5 yyhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si31184674pgj.263.2019.07.31.01.47.14; Wed, 31 Jul 2019 01:47:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbfGaInc (ORCPT + 99 others); Wed, 31 Jul 2019 04:43:32 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45327 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbfGaInc (ORCPT ); Wed, 31 Jul 2019 04:43:32 -0400 Received: by mail-ed1-f66.google.com with SMTP id x19so59020731eda.12 for ; Wed, 31 Jul 2019 01:43:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RJYmquIS1e528+G/ixh1cYrRMeCXLDQDyBuin0HsHOE=; b=QLXWbaTtuyGF0FbKoLlzhG5WVFr8cNSh/WgVZpqIRsjkPG0tbpo3QgZc7Y8LLSy6DS d04BfTp+Yf5MBjC9n+kcAiGhBo33SRYaohs5RjoObfqO2hzfFkEc+RqGdAkEgR90I3xZ j2dN1ToUD1wVrKNVZFFdc5T6AC1fbA0YJSthDxRxUE/G5T9MA45OmRGbMux6ZDOBJS8N 2g8iCRoij4VOGsv12NaMpXADtNUEdYpqn1g7wRS3rlDE/3MppGaa5SWxvnTFt+xUzxc1 e1jaOjzbeWXiPXeZFaFfV7+//dVwm1PgKnX+va/RkyHnt1g7oCEKMkCh1AS1mV/e9jDj d5tw== X-Gm-Message-State: APjAAAWJFkKDf8hCBIq2dEIR10OoGCfK3ES4dcL+9YTNGxY1aobfaQ/4 E3/lAqoWG8QIolBZBF0Zgpl+OJrpOjk= X-Received: by 2002:a50:c8c3:: with SMTP id k3mr104612123edh.189.1564562610164; Wed, 31 Jul 2019 01:43:30 -0700 (PDT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com. [209.85.221.49]) by smtp.gmail.com with ESMTPSA id e14sm135970ejj.69.2019.07.31.01.43.29 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2019 01:43:29 -0700 (PDT) Received: by mail-wr1-f49.google.com with SMTP id 31so68735309wrm.1 for ; Wed, 31 Jul 2019 01:43:29 -0700 (PDT) X-Received: by 2002:a5d:568e:: with SMTP id f14mr51213275wrv.167.1564562609364; Wed, 31 Jul 2019 01:43:29 -0700 (PDT) MIME-Version: 1.0 References: <20190731071447.9019-1-stefan@olimex.com> <20190731071447.9019-2-stefan@olimex.com> In-Reply-To: <20190731071447.9019-2-stefan@olimex.com> From: Chen-Yu Tsai Date: Wed, 31 Jul 2019 16:43:16 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] nvmem: sunxi_sid: fix A64 SID controller support To: Stefan Mavrodiev Cc: Srinivas Kandagatla , Maxime Ripard , "moderated list:ARM/Allwinner sunXi SoC support" , open list , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 31, 2019 at 3:15 PM Stefan Mavrodiev wrote: > > Like in H3, A64 SID controller doesn't return correct data > when using direct access. It appears that on A64, SID needs > 8 bytes of word_size. > > Workaround is to enable read by registers. > > Signed-off-by: Stefan Mavrodiev Acked-by: Chen-Yu Tsai And for single patches, you don't need to write a separate cover letter. Just put whatever you need to add after the "---" separator. > --- > drivers/nvmem/sunxi_sid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c > index a079a80ddf2c..e26ef1bbf198 100644 > --- a/drivers/nvmem/sunxi_sid.c > +++ b/drivers/nvmem/sunxi_sid.c > @@ -186,6 +186,7 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = { > static const struct sunxi_sid_cfg sun50i_a64_cfg = { > .value_offset = 0x200, > .size = 0x100, > + .need_register_readout = true, > }; > > static const struct sunxi_sid_cfg sun50i_h6_cfg = { > -- > 2.17.1 >